Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components: apply design feedback to g2 ColorPicker #34285

Closed
6 tasks
ciampo opened this issue Aug 25, 2021 · 1 comment
Closed
6 tasks

Components: apply design feedback to g2 ColorPicker #34285

ciampo opened this issue Aug 25, 2021 · 1 comment
Labels
[Feature] Component System WordPress component system [Package] Components /packages/components

Comments

@ciampo
Copy link
Contributor

ciampo commented Aug 25, 2021

Part of #34284

Why

The ColorPicker component has been recently added to the Gutenberg repository and needs to go through a few design tweaks

What

Mostly design refinements that were missed in the first iteration working on the component

A/C

  • The white border on the circle controls looks too wide in the storybook compared to the design
  • The input padding is off, not sure if this is something we need to affect on all inputs or we can just start with the input + slider case.
  • spacing between slider and input is off
  • use the new settings icon from wp/icons (requires Icons: update settings icon to latest version #34288)
  • the color format dropdown should be rendered without borders, - [ ] not sure how we want to handle this at the component level since it should be an optional thing used rarely
  • the slider circular handle is too big compared to designs
@ciampo ciampo mentioned this issue Aug 25, 2021
31 tasks
@ciampo ciampo added [Feature] Component System WordPress component system [Package] Components /packages/components labels Aug 25, 2021
@ciampo ciampo changed the title Apply design feedback to g2 ColorPicker Components: apply design feedback to g2 ColorPicker Aug 25, 2021
@mtias
Copy link
Member

mtias commented Aug 25, 2021

Moving these directly to the tracking issue.

@mtias mtias closed this as completed Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Component System WordPress component system [Package] Components /packages/components
Projects
None yet
Development

No branches or pull requests

2 participants