Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Social Icons: Support gap via theme.json #34526

Closed
jasmussen opened this issue Sep 3, 2021 · 0 comments · Fixed by #35236
Closed

Social Icons: Support gap via theme.json #34526

jasmussen opened this issue Sep 3, 2021 · 0 comments · Fixed by #35236
Assignees
Labels
[Block] Social Affects the Social Block - used to display Social Media accounts [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Status] In Progress Tracking issues with work in progress

Comments

@jasmussen
Copy link
Contributor

What problem does this address?

#32366 adds a theme.json mechanism to provide a a blockGap value to space out items in a container. Spacing using gap has the benefit of letting you not worry about the first or last elements in a container, or complex nth-child margins in containers that wrap.

#34493 is already refactoring the social links block to use the new blockGap value.

What is your proposed solution?

As a next step, it would be nice to connect the block with theme.json, so that the block becomes a flex container with a custom gap value, such as this:

"core/social-links": {
	"spacing": {
		"blockGap": "2em"
	}
}

#33991 also provided a UI for the gap control, which would benefit here as well.

@jasmussen jasmussen added [Block] Social Affects the Social Block - used to display Social Media accounts Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi labels Sep 3, 2021
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Social Affects the Social Block - used to display Social Media accounts [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Status] In Progress Tracking issues with work in progress
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants