-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improving the Group block Layout panel #34558
Comments
Thanks for raising the discussion @richtabor!
For block gap at least, we have a control that was introduced in #33991 as part of the Dimensions panel, to sit alongside padding and margins for those blocks that opt-in to the Would it work to opt the Group block in to use that support (it already has the server-rendering of the CSS variable, etc hooked up, too)? It would mean that the spacing would sit next to padding under Dimensions in the sidebar, instead of under Layout. |
Hi Rich! I agree that this panel needs some design explorations and iterations to get right. Related issues #31950 and #33687 First I'd like to react conceptually on the proposal above. For me it misses an important piece: alignments don't make any sense in the horizontal layout (or row) and each "layout type" (now we only have horizontal/flex and vertical/flow) can have completely different options. Later we'll have more layouts (sidebar, grid,... with their own custom options)
This one seems like a quick win we can do today.
The group block should be using the block support introduced here #33991 indeed, moving it to layout panel could be an option if needed. |
@richtabor, it’s great to see this explored visually and coming together with the iterated language. It looks like: #34574 has a lot of advancements coming, which is really exciting to see. Though there is still room for iteration around alignments, I’d be interested in the quick wins here and see what is left to work on. For me, I am not totally convinced on the longevity of content/wide - but that doesn’t mean I have a better option today for that.
+1 |
@youknowriad Gap seems more like a layout feature to me. If I set horizontal or vertical blocks, I would expect to next be able to adjust the space between them. But I understand the idea of standardizing the Dimensions UI across blocks that support blockGap. For Dimensions, are there other plans aside from Margin and Padding?
I agree. Definitely needs some logic here, to perhaps remove those controls if its set to a flex-row layout. Overall though, I think we need a grand vision for what the sidebar components of the Group block are, and how each of those will relate. |
I think folks were working on adding height, widths |
Apart from the widths in the current Layout panel? Width applied the the selected block? |
@richtabor yes, that's the idea, I think in some blocks like Cover, Media & Text, there's also min height. |
I've been trawling the Issues this morning and not finding my query/suggestion, so I guess I should create a new one, but since it's loosely related to this one I thought I'd enquire here first. The query applies to the UX (and DX) of content widths and alignments in general but is certainly most relevant to the Group block in the block theme we're currently building. At the moment if I understand correctly for layout/alignment/width (for blocks which have the Layout panel) we have these two choices:
The choice between single-preset or free-assignment seems to me to end up in a bad UX for the writers / editors who eventually use the editor, because in the case where you want different alignment/width settings for some blocks, authors then have to remember that they have to remember to manually put in unintuitive and arbitrary values like It would be better, I think, to have the option of additional preset layouts configured in Maybe something in
Related to this, I'm seeing tons of repeated inline CSS for Keen to hear everyone's feedback! |
Perhaps we can get some kind of status update along with thoughts on how we should move forward? |
Let's organize around the Group block's "Layout" panel, will house the newer layout, blockGap and user-defined child block alignment settings.
This panel may very well be one of more significant experiences we create. Making this simple and delightful will empower users to lay out child blocks within a Group with more ease and control than they've ever had.
New layout-related controls:
Current:
Proposal:
Using the ToolsPanel
Customize the width for all blocks assigned to the center or wide columns.
New control for "Display"
flex
is a more technical term, but is used within thedisplay
CSS property.New control for "Block spacing"
Make "inherit default layout" toggle clearer
Thoughts?
The text was updated successfully, but these errors were encountered: