Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter the nesting level of items in the navigation block #34611

Closed
Tracked by #35521
draganescu opened this issue Sep 7, 2021 · 2 comments · Fixed by #38621
Closed
Tracked by #35521

Filter the nesting level of items in the navigation block #34611

draganescu opened this issue Sep 7, 2021 · 2 comments · Fixed by #38621
Assignees
Labels
[Block] Navigation Affects the Navigation Block Needs Decision Needs a decision to be actionable or relevant [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@draganescu
Copy link
Contributor

Draft

We're currently hardcoding the nesting level of links in the navigation block to 5. I believe we should allow people to change this value.

@draganescu draganescu self-assigned this Sep 7, 2021
@skorasaurus skorasaurus added [Block] Navigation Affects the Navigation Block Needs Decision Needs a decision to be actionable or relevant [Type] Enhancement A suggestion for improvement. labels Sep 7, 2021
@talldan
Copy link
Contributor

talldan commented Sep 8, 2021

This might be a silly idea, but what if it were a prop of the Edit component so that it could be filtered using the existing BlockEdit filter. e.g.:

NavigationLinkEdit( { maxNestingLevel = 5, // ... } ) {

@draganescu
Copy link
Contributor Author

That's actually not a bad idea at all. We reuse a filter why add another one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block Needs Decision Needs a decision to be actionable or relevant [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants