Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RangeControl marks styling regression #35153

Closed
stokesman opened this issue Sep 27, 2021 · 4 comments
Closed

RangeControl marks styling regression #35153

stokesman opened this issue Sep 27, 2021 · 4 comments
Labels
CSS Styling Related to editor and front end styles, CSS-specific issues. [Package] Components /packages/components [Type] Regression Related to a regression in the latest release

Comments

@stokesman
Copy link
Contributor

stokesman commented Sep 27, 2021

Description

The marks in RangeControl are vertically off-center.

I've visited the WordPress Design Library looking for any specs on the mark placement. I found the designs for range controls but could not find any of them with marks.

Given the lack of specs, I'd recommend adjusting them vertically to center on the rail since they were like that originally.

Current Styling

image

Expected Styling (from #26745)

range-controls-fixed-negative-min

Step-by-step reproduction instructions

Check the marks story for RangeControl in storybook.

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@stokesman stokesman added [Type] Regression Related to a regression in the latest release [Package] Components /packages/components CSS Styling Related to editor and front end styles, CSS-specific issues. labels Sep 27, 2021
@HILAYTRIVEDI
Copy link
Contributor

HILAYTRIVEDI commented Sep 28, 2021

@stokesman
Copy link
Contributor Author

Thanks for testing this @HILAYTRIVEDI. I see from your screenshot that they are not off the rails completely but they are still not as expected. Posting a portion of your image here:

image

The marks should be vertically centered on the rails.

@HILAYTRIVEDI
Copy link
Contributor

HILAYTRIVEDI commented Sep 29, 2021

#Range control marks center aligned #35206
@stokesman I made the required code changes in this PR. Please review, thank you.

@ciampo
Copy link
Contributor

ciampo commented Aug 15, 2024

Looks like #64481 was opened (and recently fixed) for this same issue. Going to close this PR.

@ciampo ciampo closed this as completed Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CSS Styling Related to editor and front end styles, CSS-specific issues. [Package] Components /packages/components [Type] Regression Related to a regression in the latest release
Projects
None yet
Development

No branches or pull requests

3 participants