-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider notice or preventing blocks from going in positions in full site editor where they will not work #35162
Comments
Thanks for opening this! I know there are a few efforts to make blocks more "context aware" (for ex with intrinsic design options). Some of this reminds me of discussions with the Navigation Block (#30159) so, for now, I'm going to cc a few folks into the convo: @ntsekouras (for the query loop context) and @jasmussen (for the navigation block context). |
I chatted with Tammie and we worked through the various cases to reproduce:
I did a quick similar test with the Navigation block which similarly limits Page Links from being moved outside of the Navigation block, and noted that I can neither drag it outside in the list view, or copy paste it outside. So it seems like a fix is to investigate why it's possible to move the query pagination outside, and potentially fix that. |
👋 - I couldn't reproduce any unexpected behavior with I tried both in post and site editors:
All pagination related blocks have the |
This issue spills out of the site editor into the post editor as well. It's currently possible to insert blocks like Post Content and Term Description in a post or page, which makes no sense at all (unless you have a Query in a post 🙈).
I wonder if the simplest solution is to contextually hide the block from the UI (inserter / quick inserter)? IE if I'm editing a post, there should be no way for me to find the Term Description block at all. FWIW there are a number of circumstances in which this contextual awareness will be beneficial. These issues are related: |
This is a different issue whether to contextually hide/show some blocks. If the above issue can be reproduced, it's a bug in our block handling logic. |
Fair enough. I suppose I'm just highlighting that there are various situations in the UX where this contextual awareness would be useful, in case it's something we can build in at a low level and utilise in these different circumstances. |
@ntsekouras were you using Chrome? I just wonder if that could be the problem as I am puzzled because pretty consistently I can copy/paste and do any of the steps @jasmussen outlined. |
I only tested the query (post template) and query pagination, and I am seeing the same as @ntsekouras, I can not insert, drag or copy/paste the blocks outside the parent query loop. Chrome and Opera on Windows. In the site editor, when I copy the post template, and then paste it, |
Yes |
This came up as a piece of feedback during the tenth call for testing for the FSE Outreach program:
post.categories.mov |
The spinning issue for Post terms/categories has been fixed here: #35957 |
Certain blocks need to be placed with or within others to work in the full site editor. For example query pagination, doesn't work unless you put it in the query loop. However, you can place this anywhere on the site editor. This could easily lead to confusion. Whilst it does make sense that it works in the loop, it might be presumed knowledge others might not have. By limiting the use or notifying, creates a good experience for everyone and prevents frustration.
There are two options here I can think of, but there might be more:
I understand this mechanism does need design, but I also think it needs discussion, so for now, adding the feedback label first.
The text was updated successfully, but these errors were encountered: