Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Navigation Link and Submenu label classname to match other generic classnames #35238

Closed
tellthemachines opened this issue Sep 30, 2021 · 0 comments
Labels
[Block] Navigation Link Affects the Navigation Link Block [Block] Submenu Affects the Submenu Block - for submenus in navigation

Comments

@tellthemachines
Copy link
Contributor

What problem does this address?

#33918 added generic classnames across several blocks used inside the Navigation block, using wp-block-navigation-item__[element] as the general pattern. One classname seems to have escaped this update: wp-block-navigation-link__label, which is added to the span wrapping the text on both the Navigation Link and Submenu parent element. This classname is rendered on the Submenu even when the parent item is a button, so naming it "link" doesn't make much sense.

What is your proposed solution?

Replace wp-block-navigation-link__label with wp-block-navigation-item__label on both blocks, to match the current naming pattern.

@tellthemachines tellthemachines added [Block] Navigation Link Affects the Navigation Link Block [Block] Submenu Affects the Submenu Block - for submenus in navigation labels Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Link Affects the Navigation Link Block [Block] Submenu Affects the Submenu Block - for submenus in navigation
Projects
None yet
Development

No branches or pull requests

2 participants