Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storybook: Add LTR/RTL switching #35642

Closed
mirka opened this issue Oct 14, 2021 · 0 comments · Fixed by #35711
Closed

Storybook: Add LTR/RTL switching #35642

mirka opened this issue Oct 14, 2021 · 0 comments · Fixed by #35711
Assignees
@mirka
Labels
Developer Experience Ideas about improving block and theme developer experience [Feature] Component System WordPress component system Internationalization (i18n) Issues or PRs related to internationalization efforts [Status] In Progress Tracking issues with work in progress Storybook Storybook and its stories for components

Comments

@mirka
Copy link
Member

mirka commented Oct 14, 2021 •
edited
Loading

What problem does this address?

It would be easier to test for RTL language support in our components if there was a text direction switcher in the Storybook.

What is your proposed solution?

Install an addon like https://storybook.js.org/addons/storybook-rtl-addon. We may also need a mock for i18n.isRTL().
@mirka mirka added Internationalization (i18n) Issues or PRs related to internationalization efforts Storybook Storybook and its stories for components [Feature] Component System WordPress component system Developer Experience Ideas about improving block and theme developer experience labels Oct 14, 2021
@mirka mirka changed the title Components: Add LTR/RTL switching to Storybook Storybook: Add LTR/RTL switching Oct 15, 2021
@mirka mirka mentioned this issue Oct 15, 2021
Merged
7 tasks
@mirka mirka self-assigned this Oct 15, 2021
@mirka mirka mentioned this issue Oct 18, 2021
Merged
7 tasks
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Oct 18, 2021
This was referenced Oct 22, 2023
Open
Open
@soloinovator soloinovator mentioned this issue Oct 22, 2023
Open
This was referenced Oct 22, 2023
Open
Open
@npneeraj npneeraj mentioned this issue Oct 22, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mirka mirka

Labels
Developer Experience Ideas about improving block and theme developer experience [Feature] Component System WordPress component system Internationalization (i18n) Issues or PRs related to internationalization efforts [Status] In Progress Tracking issues with work in progress Storybook Storybook and its stories for components
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Storybook: Add RTL switcher to toolbar WordPress/gutenberg
1 participant
@mirka