Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RNMobile] Improve how URLs are populated in embed blocks from device clipboard #35888

Open
jhnstn opened this issue Oct 22, 2021 · 3 comments
Open
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later [Type] Enhancement A suggestion for improvement.

Comments

@jhnstn
Copy link
Contributor

jhnstn commented Oct 22, 2021

What problem does this address?

While testing iOS 18.5 I noticed when adding a YouTube embed block with an Instagram url in my clipboard, the link input was auto populated with the domain name (instagram.com) cut off from the view. When I inserted the block an Instagram block appeared. I didn't expect the YouTube embed to accept a url from another embed service. It was also difficult to know I had a URL from a different service in my clipboard since the cursor was placed at the right end of the text hiding the domain name.

What is your proposed solution?

Embed blocks should not auto populate the link field from the device clipboard if the url is from a different service.
Additionally we might want to consider placing the cursor of an auto pasted url to the left of the text so the domain name is clear.

@jhnstn jhnstn added [Type] Enhancement A suggestion for improvement. Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) labels Oct 22, 2021
@hypest
Copy link
Contributor

hypest commented Oct 25, 2021

WDYT @jd-alexander since you worked on the embed block on native? Is this perhaps intended behaviour?

cc @fluiddot for the FYI as you are on scheduled leave at the moment.

@jd-alexander
Copy link
Contributor

WDYT @jd-alexander since you worked on the embed block on native? Is this perhaps intended behaviour?

cc @fluiddot for the FYI as you are on scheduled leave at the moment.

Thanks for the ping @hypest This behavior is expected. On the web the Embed block performs this upgrade operation when varying providers are used on specific Embed variants.

@jd-alexander
Copy link
Contributor

Thanks for sharing the proposed solution @jhnstn I will take a look at this behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later [Type] Enhancement A suggestion for improvement.
Projects
None yet
4 participants