Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to edit the "default layout" in the Global Styles panel #35955

Closed
kjellr opened this issue Oct 26, 2021 · 6 comments · Fixed by #42309
Closed

Allow users to edit the "default layout" in the Global Styles panel #35955

kjellr opened this issue Oct 26, 2021 · 6 comments · Fixed by #42309
Assignees
Labels
[Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@kjellr
Copy link
Contributor

kjellr commented Oct 26, 2021

Whenever you see a block with a "Layout" panel, you're able to select "Inherit default layout." This setting pulls from the theme options to provide a default layout.

It seems natural that users would be able to edit these values in the "Layout" section of Global Styles, but they're not there currently:

Screen Shot 2021-10-26 at 8 20 37 AM

(I searched before posting this, and was surprised that there wasn't an existing issue for this?)

@kjellr kjellr added [Type] Enhancement A suggestion for improvement. Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi labels Oct 26, 2021
@kjellr kjellr changed the title Show "default layout" options in the "layout" Global Styles panel Allow users to edit the "default layout" in the Global Styles panel Oct 26, 2021
@paaljoachim
Copy link
Contributor

I believe that Jorge and Andre @jorgefilipecosta @oandregal would like to know about this issue.
Thank you for creating it @kjellr Kjell!

@ellenbauer
Copy link

I second that, I already had a few of our block theme users ask where they can change the theme's default width. This would be a very helpful addition to Global Styles.

Plus somehow Gutenberg 11.9.0 doesn't give access to general Layout settings. Is this intended?

@jorgefilipecosta
Copy link
Member

So the issue here is on the block inspector of the normal post editor we should show the values that were set on theme.json?

I guess if so it is a matter of merging #34178 that does not for line-height and expand to other styles.

@kjellr
Copy link
Contributor Author

kjellr commented Nov 15, 2021

Not quite — we don't show layout settings at all in Global Styles right now, but I think we should do so.

Today Suggested
138877953-20f1eb88-bb44-42fb-9ec0-1f5eb476aca9 Frame 4

(The layout settings there would show the default values from theme.json)

@jorgefilipecosta
Copy link
Member

Not quite — we don't show layout settings at all in Global Styles right now, but I think we should do so.

Today Suggested
138877953-20f1eb88-bb44-42fb-9ec0-1f5eb476aca9 Frame 4
(The layout settings there would show the default values from theme.json)

@youknowriad do you think we can expand the layouts panel in 5.9 with these additional styles?

@iamtakashi
Copy link

+1 on this. Thanks for creating it, @kjellr!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants