Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display the site name in the top bar in Appearance > Editor #36207

Closed
jameskoster opened this issue Nov 4, 2021 · 6 comments
Closed

Display the site name in the top bar in Appearance > Editor #36207

jameskoster opened this issue Nov 4, 2021 · 6 comments
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.

Comments

@jameskoster
Copy link
Contributor

Currently the top bar in the Site Editor displays the name of the template being edited, and this works well when you edit a template in isolation (IE via Appearance > Templates). But clicking Appearance > Editor takes you to a unique view where you might be editing template and content all at the same time.

For example: If your site is configured to display a static home page, Appearance > Editor takes you to a view where you're editing whichever template is used to display that page. This could be anything from a Theme supplied "Page" or "Index" template, to a custom template created by the user, with any name. In this view users are also able to edit the contents of that page, so displaying the template name alone in the top bar also feels like a mis-representation.

If your site is configured to display latest posts on the home page instead, then Appearance > Editor will take you to a view where you're editing either the Index or Home template (depending on what your theme supplies). But similar to the static home page scenario, it's also possible to edit the posts themselves in this view as well. So once again, the template name is not an intuitive title for this experience.

All of this is made worse by the fact that template names like "Index" are not particularly user-friendly!

Screenshot 2021-11-04 at 10 33 30

Since we are removing the navigation in the Site Editor for 5.9 (#36194) we can think more critically about what to display in the top bar.


My initial supposition is that it might be better to simply display the site name, or URL in the top bar when you access the site editor via Appearance > Editor. This can also serve as a link to view the frontend, which is a feature folks have been asking for in the Site Editor for a long time:

Screenshot 2021-11-04 at 10 33 38

To clarify, this would only appear when a user clicks Appearance > Editor. If you edit a template via Appearance > Template, then it still makes sense to just display the template name in the top bar.


Without wanting to get too far ahead of myself, this could potentially lay the foundation for a way to navigate around content in the Site Editor in the future as well:

Screenshot 2021-11-04 at 10 44 42

@jameskoster jameskoster added the [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") label Nov 4, 2021
@carolinan
Copy link
Contributor

So the entire template details modal is removed?

@carolinan
Copy link
Contributor

Then is there a new flow for resetting saved changes to the theme default (the HTML file)?

@jameskoster
Copy link
Contributor Author

jameskoster commented Nov 5, 2021

The template details would still be present in the Inspector.

Then is there a new flow for resetting saved changes to the theme default (the HTML file)?

Good catch. This may or may not be a good thing – since in Editor beta you can be editing template and content together, "Reset customizations" could mislead folks in to thinking their content changes would be reset too.

If we want to keep this flow in Editor beta we may want to add it to the Inspector, something like:

Screenshot 2021-11-05 at 13 56 38

@jameskoster
Copy link
Contributor Author

Just noting that if we were to do this, we could close out #35758.

@annezazu
Copy link
Contributor

With this closed out #35758 can we close this issue out too? I am not quite seeing the overlap with current explorations: #36667

@jameskoster
Copy link
Contributor Author

What to display in the top bar still doesn't feel very clear. Probably fine to close this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

5 participants