Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RichText: Unable to add a custom highlight color #36254

Closed
WunderBart opened this issue Nov 5, 2021 · 2 comments · Fixed by #36263
Closed

RichText: Unable to add a custom highlight color #36254

WunderBart opened this issue Nov 5, 2021 · 2 comments · Fixed by #36263
Labels
[Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable [Type] Bug An existing feature does not function as intended

Comments

@WunderBart
Copy link
Member

Description

When trying to highlight text with a custom color, the input doesn't accept any new characters, and when trying to delete any character the popup menu closes. It seems to have been introduced with v11.8.0 as in my testing v11.7.1 works correctly (see demo videos).

Step-by-step reproduction instructions

  1. Write some text into a paragraph block
  2. Select a part of this text
  3. Open the Highlight menu from the rich text toolbar
  4. Try to apply custom color via the text input (see demo)
  5. See how the current value cannot be changed

Screenshots, screen recording, code snippet

Current Gutenberg version v11.8.0 (broken):

Screen.Recording.2021-11-05.at.13.03.10.mov

Previous Gutenberg version v11.7.1 (working):

Screen.Recording.2021-11-05.at.12.55.35.mov

Environment info

  • WP 5.8.1
  • Gutenberg v11.8.0
  • Chrome

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@WunderBart WunderBart added [Type] Bug An existing feature does not function as intended [Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable labels Nov 5, 2021
@alshakero
Copy link
Contributor

Can confirm this is reproducible in trunk.

@alshakero
Copy link
Contributor

PR ready #36263

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants