Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full Site Editing: Ensure that the site editor canvas loads only after the global styles are ready. #36594

Closed
youknowriad opened this issue Nov 18, 2021 · 2 comments · Fixed by #36643
Assignees
Labels
[Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@youknowriad
Copy link
Contributor

Description

An attempt to fix this has been done in #36044 that said, it seems it is still possible to experience this in some situations. Basically when you load the site editor, the canvas should only be rendered with the correct styles directly. While right now, it's possible to actually see the canvas unstyled for some milliseconds and then the global styles get applied.

Step-by-step reproduction instructions

I'm not sure exactly about the exact instructions to reproduce. I've been able to see this with just a basic 2022 theme installation. That said for now, we should just test it, audit it and if we find a good way to reproduce, fix it.

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@youknowriad youknowriad added [Type] Bug An existing feature does not function as intended [Feature] Full Site Editing labels Nov 18, 2021
@jameskoster
Copy link
Contributor

I believe this is somewhat related: #35503

@annezazu
Copy link
Contributor

annezazu commented Nov 19, 2021

Just noting that I can replicate with a fairly empty install using the Tove theme, latest version of Gutenberg (11.9.1), and WordPress 5.8.2. Here's a short video both showing how it sometimes does and doesn't happen though:

replicate.styling.mov

I'm a visual person so thought the video would help others understand :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants