Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Editor: Use <table> in templates list page #36702

Closed
noisysocks opened this issue Nov 21, 2021 · 0 comments · Fixed by #36707
Closed

Site Editor: Use <table> in templates list page #36702

noisysocks opened this issue Nov 21, 2021 · 0 comments · Fixed by #36707
Assignees
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@noisysocks
Copy link
Member

noisysocks commented Nov 21, 2021

The templates list page added in #36379 uses a <ul> for the markup that displays the templates available to edit.

Screen Shot 2021-11-22 at 10 40 57 am

<table> is the more semantically correct element to use here as we are presenting tabular data ("data with multiple dimensions") to the user. It also assists screen readers, as @talldan summarises in #36379 (comment):

When tabbing through a table, a screen reader user will be informed which column and row they're in, and when entering the table for the first time how many columns and rows there are. With a list, the user will only know how many list items, and won't be aware of columns.

@noisysocks noisysocks changed the title Accessibility review (⚠️ ) Site Editor: Use <table> in templates list page Nov 21, 2021
@noisysocks noisysocks added [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Bug An existing feature does not function as intended [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). labels Nov 21, 2021
@kevin940726 kevin940726 self-assigned this Nov 22, 2021
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants