Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more unit tests to NumberControl and RangeControl #36742

Open
2 tasks
ciampo opened this issue Nov 22, 2021 · 0 comments
Open
2 tasks

Add more unit tests to NumberControl and RangeControl #36742

ciampo opened this issue Nov 22, 2021 · 0 comments
Labels
[Feature] Component System WordPress component system [Package] Components /packages/components [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Type] Enhancement A suggestion for improvement.

Comments

@ciampo
Copy link
Contributor

ciampo commented Nov 22, 2021

What

Following up on #34817, we should add more unit tests to NumberControl and RangeControl

Why

The work done in #35020 and #34542 showed how these components can be quite tricky to iterate on. We should add more unit tests to ensure that we don't introduce regressions when working on them

Acceptance Criteria
@ciampo ciampo added [Type] Enhancement A suggestion for improvement. [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Package] Components /packages/components [Feature] Component System WordPress component system labels Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Component System WordPress component system [Package] Components /packages/components [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ciampo