Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Site Editor: undo problem with Cover block #36781

Closed
vindl opened this issue Nov 23, 2021 · 1 comment · Fixed by #36807
Closed

Site Editor: undo problem with Cover block #36781

vindl opened this issue Nov 23, 2021 · 1 comment · Fixed by #36807
Assignees
@Mamaduka
Labels
[Block] Cover Affects the Cover Block - used to display content laid over a background image [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@vindl
Copy link
Member

vindl commented Nov 23, 2021 •
edited
Loading

Description

When you insert the cover block in the Site Editor, it takes two undo actions to remove it. This is not happening for other blocks that I tested.

Step-by-step reproduction instructions

  1. Go to wp-admin/site-editor.php
  2. Insert the Cover block anywhere on the homepage.
  3. Press Undo. Notice that the action is not reverted.
  4. Press Undo again. The Cover block is now removed.

Screenshots, screen recording, code snippet

No response

Environment info

WordPress version: 5.9-alpha-52232
Gutenberg version: 12.0.0-rc.1
Theme: Twenty Twenty-Two v1.0

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes
@vindl vindl added [Type] Bug An existing feature does not function as intended [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Nov 23, 2021
@Mamaduka Mamaduka self-assigned this Nov 24, 2021
@Mamaduka Mamaduka added the [Status] In Progress Tracking issues with work in progress label Nov 24, 2021
@Mamaduka Mamaduka mentioned this issue Nov 24, 2021
Merged
7 tasks
@Mamaduka
Copy link
Member

@vindl PR is ready for review. I'm changing the "Site Editor" label to "Cover" since it's a general blog issue unrelated to the editors.

@Mamaduka Mamaduka added [Block] Cover Affects the Cover Block - used to display content laid over a background image and removed [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mamaduka Mamaduka

Labels
[Block] Cover Affects the Cover Block - used to display content laid over a background image [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cover: Fix undo trap WordPress/gutenberg
2 participants
@Mamaduka @vindl