Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add e2e test to cover Nav block front end fallbacks #36825

Open
getdave opened this issue Nov 24, 2021 · 0 comments
Open

Add e2e test to cover Nav block front end fallbacks #36825

getdave opened this issue Nov 24, 2021 · 0 comments
Assignees
@getdave
Labels
[Package] E2E Tests /packages/e2e-tests [Type] Enhancement A suggestion for improvement.

Comments

@getdave
Copy link
Contributor

getdave commented Nov 24, 2021

In #36740 we added functionality to provide a fallback for the Nav block.

Let's improve test coverage around that by adding e2e tests.

I left a few suggestions related to naming, but otherwise this looks good to me! If you added a test or two, that would be absolutely stellar. Otherwise, 🚢

Originally posted by @adamziel in #36740 (review)
@getdave getdave self-assigned this Nov 24, 2021
@skorasaurus skorasaurus added the [Package] E2E Tests /packages/e2e-tests label Dec 1, 2021
@jordesign jordesign added the [Type] Enhancement A suggestion for improvement. label Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@getdave getdave

Labels
[Package] E2E Tests /packages/e2e-tests [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@getdave @skorasaurus @jordesign