Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block Styles: Layout changes when selecting background colors. #36971

Open
Addison-Stavlo opened this issue Nov 29, 2021 · 1 comment
Open

Block Styles: Layout changes when selecting background colors. #36971

Addison-Stavlo opened this issue Nov 29, 2021 · 1 comment
Labels
[Feature] Colors Color management [Feature] Custom Editor Styles Functionality for adding custom editor styles [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Bug An existing feature does not function as intended

Comments

@Addison-Stavlo
Copy link
Contributor

Addison-Stavlo commented Nov 29, 2021

The Issue

In FSE lets take the header in tt1-blocks as an example. If we change the color setting of a wrapper block inside the header, the layout of all the blocks shift as a result:
layout-shift-background-color

This behavior is the same whether it was the recently removed color setting of the template part block, an internal group block wrapping the inner content, an internal columns block, etc. Nor is it limited to the template part. This is reproducible with the majority of blocks, even the paragraph. It is not limited to FSE or tt1-blocks as we can reproduce with blocks in twnety-nineteen and other themes, however it seems like a vitally important problem to solve for FSE.

What I would expect

Color settings and layout/padding settings to operate independently. Blocks should have the same paddings and alignment regardless of whether or not the user has added a custom background. I should be able to change the background color of my header (or any other block) without any other visible changes.

Why is this an issue

Conflating layout properties with color properties imposes unnecessary limits on the styles that are possible of achieving within the editor. If we want to give users the power to customize styles in the editor without a need for custom CSS, this requires resolution.

@Addison-Stavlo Addison-Stavlo added [Type] Bug An existing feature does not function as intended [Feature] Custom Editor Styles Functionality for adding custom editor styles [Feature] Full Site Editing labels Nov 29, 2021
@carolinan
Copy link
Contributor

Related:
#30725

@Addison-Stavlo Addison-Stavlo added the [Feature] Colors Color management label Jun 15, 2022
@annezazu annezazu added [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") and removed [Feature] Full Site Editing labels Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Colors Color management [Feature] Custom Editor Styles Functionality for adding custom editor styles [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

3 participants