Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrapping Heading block text overlaps previous lines for block-based themes #37168

Closed
dcalhoun opened this issue Dec 6, 2021 · 4 comments · Fixed by #37285 or wordpress-mobile/gutenberg-mobile#4398
Assignees
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Status] In Progress Tracking issues with work in progress

Comments

@dcalhoun
Copy link
Member

dcalhoun commented Dec 6, 2021

Description

When adding a Heading block in the native mobile editor, the line height is incorrect and results in overlapping lines of text. It would appear an incorrect line height is set for the Heading block.

This issue only occurs in development environments at the time of writing. This issue occurs in the latest v1.67.0 release and first occurred in v1.64.0. It only occurs on Android, not iOS. It is likely related to #35314.

Step-by-step reproduction instructions

  1. Set the current theme to Geologist.
  2. Add a Heading block to the editor.
  3. Type enough words to wrap the text to a second line.

Expected behaviour

The wrapped second line of text does overlaps the first line of text.

Actual behaviour

The wrapped second line of text does not overlap the first line of text.

Screenshots or screen recording (optional)

Too small of line hight for the Heading block causes wrapped text to overlap previous lines of text on Android

WordPress information

  • WordPress version: WordPress.com
  • Gutenberg version: v12.0.1
  • Are all plugins except Gutenberg deactivated? Yes
  • Are you using a default theme (e.g. Twenty Twenty-One)? No, Geologist

Device information

  • Device: Samsung Galaxy S20
  • Operating system: Android 11
  • WordPress app version: Gutenberg Mobile v1.67.0
@dcalhoun dcalhoun added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Dec 6, 2021
@dcalhoun
Copy link
Member Author

dcalhoun commented Dec 6, 2021

@geriux do you think this may be related to #35314?

@hypest
Copy link
Contributor

hypest commented Dec 7, 2021

but not in the latest WordPress mobile app release (18.8)

👋 @dcalhoun! Trying to understand the setup, do you mean that the production WP app doesn't exhibit the issue? And since I see the screenshot in the ticket being from WPAndroid, does that mean the app was pointing to a running Metro server and thus, exhibiting the issue? Thanks!

@dcalhoun
Copy link
Member Author

dcalhoun commented Dec 7, 2021

👋 @dcalhoun! Trying to understand the setup, do you mean that the production WP app doesn't exhibit the issue? And since I see the screenshot in the ticket being from WPAndroid, does that mean the app was pointing to a running Metro server and thus, exhibiting the issue?

@hypest I believe the font size feature resides behind a development flag. So, the issue is not present in a packaged release, but is present when connected to a Metro server. I will update the Issue description to improve clarity.

@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Dec 10, 2021
@geriux
Copy link
Member

geriux commented Dec 10, 2021

Hey there 👋 I'm working on a fix for this issue, as @dcalhoun mentioned this is behind a development flag so this is not happening on production. Thanks for finding this bug! 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Status] In Progress Tracking issues with work in progress
Projects
None yet
3 participants