Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore the "Save flow should work as expected" E2E test #37327

Closed
adamziel opened this issue Dec 13, 2021 · 0 comments · Fixed by #37333
Closed

Restore the "Save flow should work as expected" E2E test #37327

adamziel opened this issue Dec 13, 2021 · 0 comments · Fixed by #37333
Assignees
@ntsekouras
Labels
[Block] Post Content Affects the Post Content Block [Package] E2E Tests /packages/e2e-tests [Package] Edit Post /packages/edit-post [Status] In Progress Tracking issues with work in progress

Comments

@adamziel
Copy link
Contributor

#37157 removed the template parts support from the post editor, and added .skip() to the two e2e tests relying on that feature:

  • Multi-entity saving – Save flow should work as expected
  • Template parts – Should insert new template part on creation

The former is useful, but needs to rely on a block different than the template part. The latter doesn't seem to be useful anymore and can be just deleted.

cc @noisysocks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ntsekouras ntsekouras

Labels
[Block] Post Content Affects the Post Content Block [Package] E2E Tests /packages/e2e-tests [Package] Edit Post /packages/edit-post [Status] In Progress Tracking issues with work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix controlled blocks e2e tests after template part support from post editor WordPress/gutenberg
2 participants
@adamziel @ntsekouras