Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When customising a template from a plugin pressing the browser back button does not update the template list #37585

Closed
opr opened this issue Dec 22, 2021 · 2 comments
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Bug An existing feature does not function as intended

Comments

@opr
Copy link
Contributor

opr commented Dec 22, 2021

Description

If you customise a template in the Site Editor, then press the browser back button, attempting to edit the same item again (without refreshing the template page) theYou attempted to edit an item that doesn't exist. Perhaps it was deleted? error shows up.

Step-by-step reproduction instructions

  1. Install WooCommerce Blocks (or any other extension that adds templates to Gutenberg).
  2. Go to the site editor templates list.
  3. Find a template from a plugin that has not been customised.
  4. Customise it and press save.
  5. Use the browser back button to return to the template list.
  6. Try to edit the same template again.
  7. See the error

Screenshots, screen recording, code snippet

https://www.loom.com/share/787ffc07d7594d5798d84f1f83bab848

Environment info

Gutenberg 12.1.0 and WooCommerce blocks trunk.

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

No

@carolinan carolinan added the [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") label Dec 22, 2021
@annezazu annezazu added the [Type] Bug An existing feature does not function as intended label Jan 3, 2022
@Mamaduka
Copy link
Member

Mamaduka commented Jan 5, 2022

Since RC was already released, I'm removing this issue from WP 5.9 board.

Custom template support in plugins isn't well tested or documented feature.

Let's try to fix this for the next release.

@youknowriad
Copy link
Contributor

We now have a formal Api to register templates #65958 and I can't reproduce this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

5 participants