Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hovering on Padding/Margin control creates undo level #37606

Closed
Mamaduka opened this issue Dec 23, 2021 · 3 comments
Closed

Hovering on Padding/Margin control creates undo level #37606

Mamaduka opened this issue Dec 23, 2021 · 3 comments
Labels
[Feature] Block API API that allows to express the block paradigm. [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi

Comments

@Mamaduka
Copy link
Member

When I hover over on Padding or Marging control, it creates "undo level" in the editor.

I can see EDIT_ENTITY_RECORD in Redux logs, triggered by onChangeShowVisualizer.

How to reproduce

  1. Add a Group block to a post.
  2. Open the "Dimensions" panel and hove over padding control.
  3. New "undo level" is created.

Tested with TT2, Gutenberg trunk, and WP 5.9-beta4.

Screencast

CleanShot.2021-12-23.at.10.29.38.mp4
@Mamaduka Mamaduka added [Feature] Block API API that allows to express the block paradigm. [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi labels Dec 23, 2021
@Mamaduka
Copy link
Member Author

/cc @aaronrobertshaw

@aaronrobertshaw
Copy link
Contributor

Thanks for the ping @Mamaduka.

I think this might be a duplicate of #36418.

There are some open PRs relating to this problem already.

As you note, this issue is due to the box control visualizers storing its data within the block attributes. Rather than duplicate or fork the discussion, I'd suggest we close this issue and continue it on #36418 or the PR most likely to proceed (#33560).

@Mamaduka
Copy link
Member Author

Thank you, @aaronrobertshaw. The #33560 looks like a good candidate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Block API API that allows to express the block paradigm. [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi
Projects
None yet
Development

No branches or pull requests

2 participants