Reusable Blocks: Display reusable blocks in Autocompleter

[noisysocks]

Reusable Blocks that the user has created should appear in the Autocompleter when the user types in the Reusable Block's title.

This patch that @youknowriad wrote is a good start to doing this.

[youknowriad]

The patch uses the "editor"'s module state in the "blocks" module which is not great. But it's solvable by moving the BlockAutocomplete to a BlockListBlock component as a wrapper to BlockEdit for default blocks. cc @aduth

[aduth]

But it's solvable by moving the BlockAutocomplete to a BlockListBlock component as a wrapper to BlockEdit for default blocks.

Noting that this could potentially be implemented a few ways:

• From VisualEditor, would need a callback for rendering a single item in a block list to wrap the rendered block element
• From the BlockEdit component
• As a filter hook on BlockEdit

The issue with the second and third options is that it still assumes an editor state from within the blocks directory (where they are implemented).

This could tie into needing to refactor state to more consolidate generalized blocks and editor behaviors, while separating out post editor specific behaviors.

[noisysocks]

From VisualEditor, would need a callback for rendering a single item in a block list to wrap the rendered block element

Could you elaborate on this, @aduth? Not sure what you mean by a callback.

The issue with the second and third options is that it still assumes an editor state from within the blocks directory (where they are implemented).

We could add the BlockEdit filter in the editor module. I note that there's already a editor hook defined here.

[noisysocks]

I built out a POC of the third option @aduth listed (using a filter hook on BlockEdit) over in #4769. Let me know what you think.

[noisysocks]

#6067 fixed this.