Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global Styles sidebar header height shrinks when panel content overflows #38414

Closed
mirka opened this issue Feb 1, 2022 · 6 comments
Closed
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json

Comments

@mirka
Copy link
Member

mirka commented Feb 1, 2022

Description

The Global Styles sidebar header will shrink if the panel content is overflowing vertically.

Step-by-step reproduction instructions

  1. Go to /wp-admin/themes.php?page=gutenberg-edit-site.
  2. In the Styles sidebar, click the "Blocks" menu item. (Alternatively, use the DevTools Inspector to add extra content in the sidebar until a vertical scrollbar appears.)
  3. The sidebar header shrinks in height.

Screenshots, screen recording, code snippet

CleanShot.2022-02-02.at.00.32.13.mp4

Environment info

  • Current trunk on WP 5.9 (Does not reproduce in WP 5.9 without the Gutenberg plugin)
  • Chrome

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@mirka mirka added the Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json label Feb 1, 2022
@ciampo
Copy link
Contributor

ciampo commented Feb 2, 2022

If I understand what's being reported correctly, I see everything working as expected:

  • The sidebar has a fixed width
  • When navigating to the "Blocks" view, the content is too long and therefore the view needs to allow vertical scrolling
  • The scrollbar needs horizontal estate to render, and since the sidebar has a fixed width, the only solution is to shrink the view's content width

What would you propose as an alternative solution?

@mirka
Copy link
Member Author

mirka commented Feb 2, 2022

Yes correct, the width shrinking is fine. This issue is about the header height shrinking (48px → 37px).

@ciampo
Copy link
Contributor

ciampo commented Feb 2, 2022

Yes correct, the width shrinking is fine. This issue is about the header height shrinking (48px → 37px).

It's interesting how my brain read width instead of height through the whole issue title and description 🤦

@annezazu
Copy link
Contributor

annezazu commented Feb 9, 2022

@mirka I can't replicate this in Chrome with MacOS using 5.9 without Gutenberg. Can you share more about your setup so I can replicate?

height.mov

@annezazu annezazu added the [Status] Needs More Info Follow-up required in order to be actionable. label Feb 9, 2022
@mirka
Copy link
Member Author

mirka commented Feb 9, 2022

@annezazu Ah good catch, it does not reproduce in WP 5.9 itself in my environment either. I'll rewrite the issue description to make that clearer.

@mirka mirka removed the [Status] Needs More Info Follow-up required in order to be actionable. label Feb 11, 2022
@mirka
Copy link
Member Author

mirka commented Aug 23, 2022

Does not reproduce anymore in current trunk.

@mirka mirka closed this as completed Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json
Projects
None yet
Development

No branches or pull requests

3 participants