Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add body background image to global styles (Customizer feature parity) #38436

Closed
carolinan opened this issue Feb 2, 2022 · 6 comments
Closed
Labels
[Feature] Themes Questions or issues with incorporating or styling blocks in a theme. Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json Needs Design Needs design efforts. [Type] Enhancement A suggestion for improvement.

Comments

@carolinan
Copy link
Contributor

carolinan commented Feb 2, 2022

What problem does this address?

I am receiving support questions related to block themes, and one of the questions that has been recurring is how to add a body background image without access to the Customizer.

This is possible using the cover block. But if you want to use the same background image on all pages on the site, you need to add the block to all the templates.
In my opinion, the cover block is superior to the body background image settings that is available in the customizer, except for in this scenario, because of the effort it takes to add the image to all templates.

What is your proposed solution?

I am suggesting that a site wide body background image option could be added to the styles sidebar.

Related: #16479

@carolinan carolinan added the [Type] Enhancement A suggestion for improvement. label Feb 2, 2022
@annezazu annezazu added [Feature] Themes Questions or issues with incorporating or styling blocks in a theme. Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json labels Aug 3, 2022
@carolinan
Copy link
Contributor Author

This feature was requested by an attendee at a workshop at WCEU 2023.

@carolinan
Copy link
Contributor Author

@WordPress/gutenberg-design Where might this feature go in the Site Editor Styles sidebar?
And how would this be handled in case you want different background images on different templates? 🤔

@carolinan carolinan added the Needs Design Needs design efforts. label Aug 20, 2023
@jameskoster
Copy link
Contributor

Where might this feature go in the Site Editor Styles sidebar?

Good question, there's no obvious destination currently.

And how would this be handled in case you want different background images on different templates?

This part would be handled by #40318

@carolinan
Copy link
Contributor Author

Maybe a site-wide body background would instead be under WordPress Admin > Settings > General.

@jasmussen
Copy link
Contributor

Ideally we could find an inspector interface that worked across both individual pages/templates, and globally, and was essentially the same. Exactly like how you might customize a group locally, or in global styles → Blocks. @SaxonF you had an "Elements" section in a mockup once, any instincts here?

@annezazu
Copy link
Contributor

AFAIK this can be closed out thanks to completed work for 6.6 to add a site wide background image option to Styles under Layout: #54336

Closing out but let me know if any piece of this needs to be reopened :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Themes Questions or issues with incorporating or styling blocks in a theme. Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json Needs Design Needs design efforts. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

4 participants