Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin resizing UX to top right when image is aligned to the right #3944

Closed
2 tasks
GaryJones opened this issue Dec 12, 2017 · 4 comments
Closed
2 tasks

Pin resizing UX to top right when image is aligned to the right #3944

GaryJones opened this issue Dec 12, 2017 · 4 comments
Labels
[Feature] Media Anything that impacts the experience of managing media Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Bug An existing feature does not function as intended
Milestone

Comments

@GaryJones
Copy link
Member

GB 1.9.0

Issue Overview

When resizing images by dragging the corners, the user experience can be jarring.

Steps to Reproduce (for bugs)

  1. Open demo content page.
  2. Right-align an image.
  3. Select image, so corner drag handles appear.
  4. Resize via any corner handle.

Expected Behavior

If the image is right-aligned, then I'd expect resizing to be pinned from the top right corner so that enlarging the image expands down and to the left into the surrounding content, and not to be outside of the content column, only to then snap back.

Current Behavior

Even though the image is right-aligned, it's the top-left corner which is "pinned" while the image gets bigger down and to the right from this point. This typically means the image expands outside of the content column during resizing, and then "snaps" back into place, changing both the position of the image and it's surrounding box.

Compare how awkward this feels, compared to when the image is left-aligned.

The "after-resize" behaviour is correct - it's the "during-resize" behaviour that I think could be improved.

Possible Solution

"Pin" resizing behaviour to the top right if the image is right aligned.

Screenshots / Video

Animation showing image resizing

Todos

  • Tests
  • Documentation
@danielbachhuber danielbachhuber added the [Type] Bug An existing feature does not function as intended label Jan 23, 2018
@danielbachhuber danielbachhuber changed the title UX: Resizing aligned images Pin resizing UX to top right when image is aligned to the right Jan 23, 2018
@danielbachhuber danielbachhuber added Good First Issue An issue that's suitable for someone looking to contribute for the first time [Feature] Media Anything that impacts the experience of managing media labels Jan 23, 2018
@danielbachhuber
Copy link
Member

Thanks for the great bug report, @GaryJones

@karmatosed karmatosed added this to the Merge Proposal milestone Jan 25, 2018
@pento pento mentioned this issue Feb 23, 2018
3 tasks
@jeffpaul
Copy link
Member

This ticket was mentioned in Slack in #core-editor by jeffpaul. View the logs.

@karmatosed karmatosed modified the milestones: Merge Proposal, Merge Proposal: Media Apr 12, 2018
@karmatosed
Copy link
Member

I just tested this and it seems to work now, if this is still an issue please let me know and we can reopen. Maybe this is browser related now so having that information would be great.

@GaryJones
Copy link
Member Author

I also just tested this on GB 2.7.0, and it seems to work correctly, including when the image is centered:

gutenberg-image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Media Anything that impacts the experience of managing media Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

4 participants