Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Theme Export: CSS variables encoded on export #39576

Closed
scruffian opened this issue Mar 18, 2022 · 2 comments
Closed

Theme Export: CSS variables encoded on export #39576

scruffian opened this issue Mar 18, 2022 · 2 comments
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Feature] Themes Questions or issues with incorporating or styling blocks in a theme.

Comments

@scruffian
Copy link
Contributor

Description

The templates that had CSS variables when exporting turn into:

Step-by-step reproduction instructions

  1. Export a theme from the Site Editor
  2. Find a template that contains a CSS variable
  3. Notice that the CSS variables are encoded

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes
@scruffian scruffian added [Feature] Themes Questions or issues with incorporating or styling blocks in a theme. [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Mar 18, 2022
@scruffian scruffian mentioned this issue Mar 18, 2022
Merged
@scruffian
Copy link
Contributor Author

Update: I don't think this happens on export it happens when you save the content in the template editor...

@scruffian
Copy link
Contributor Author

After talking about this to @dmsnell I think this is actually the intended behaviour. We should be escaping these values to ensure that we avoid the risk of breaking things in the site editor. I'm going to close this one for now.

@scruffian scruffian mentioned this issue Mar 28, 2022
Merged
@scruffian scruffian mentioned this issue Apr 28, 2022
Closed
@draganescu draganescu mentioned this issue May 5, 2022
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Feature] Themes Questions or issues with incorporating or styling blocks in a theme.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@scruffian