Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce length of text label for Navigation Menu sidebar header button #39803

Open
getdave opened this issue Mar 28, 2022 · 3 comments
Open

Reduce length of text label for Navigation Menu sidebar header button #39803

getdave opened this issue Mar 28, 2022 · 3 comments
Assignees
@getdave
Labels
[Feature] Navigation in Site View Navigation section in the Site Editor when in Site View, offering a way to manage Navigation Menus a [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Enhancement A suggestion for improvement.

Comments

@getdave
Copy link
Contributor

getdave commented Mar 28, 2022 •
edited
Loading

We might want to think of a shorter text label for the header button, because "Navigation Menus" is taking up a lot of space when button text labels are enabled:

See #39290 (comment)

As suggested there let's shorten the text based label so that it's not taking up so much room.
@getdave getdave added [Type] Enhancement A suggestion for improvement. [Feature] Navigation in Site View Navigation section in the Site Editor when in Site View, offering a way to manage Navigation Menus a labels Mar 28, 2022
@getdave getdave self-assigned this Mar 28, 2022
@getdave getdave mentioned this issue Mar 28, 2022
Merged
5 tasks
@tellthemachines tellthemachines added the [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). label Apr 1, 2022
@github-actions
Copy link

Hi,
This issue has gone 180 days without any activity. This means it is time for a check-in to make sure it is still relevant. If you are still experiencing this issue with the latest versions, you can help the project by responding to confirm the problem and by providing any updated reproduction steps.
Thanks for helping out.

@github-actions github-actions bot added the Needs Testing Needs further testing to be confirmed. label Sep 28, 2022
@Thelmachido
Copy link

Hi, @getdave there hasn't been much movement on the related PR since April, is there still a plan to move forward with this?

If that is the case please remove the stale label and probably add more information

@getdave getdave removed the Needs Testing Needs further testing to be confirmed. label Oct 4, 2022
@getdave
Copy link
Contributor Author

getdave commented Oct 4, 2022

This is still valid. I don't see a related PR however.

The Nav sidebar hasn't seen much progress in the 6.1 cycle which is why this is flagging as stale. It's still valid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@getdave getdave

Labels
[Feature] Navigation in Site View Navigation section in the Site Editor when in Site View, offering a way to manage Navigation Menus a [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@getdave @tellthemachines @Thelmachido