Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto select first Nav Menu in Nav block if only a single wp_navigation exists #39854

Closed
getdave opened this issue Mar 29, 2022 · 3 comments
Closed
Assignees
Labels
[Block] Navigation Affects the Navigation Block Needs Testing Needs further testing to be confirmed.

Comments

@getdave
Copy link
Contributor

getdave commented Mar 29, 2022

Currently when switching to a new Theme the Nav block requires the user to select the Nav Menu they wish to use in the Nav block. This is because there is no mechanism to decide on the most "appropriate" Nav Menu to use.

In order to optimise for the 80% use case where the user has a single Navigation Menu, let's update the block to automatically use the first Navigation Menu if there is only a single wp_navigation post.

cc @mtias @scruffian

@getdave getdave added the [Block] Navigation Affects the Navigation Block label Mar 29, 2022
@getdave getdave self-assigned this Mar 29, 2022
@mtias
Copy link
Member

mtias commented Mar 29, 2022

To contextualize a bit more this idea, the general aim is to make the navigation renderer just work with the user's stored menu. The assumption being that if there is a single menu on a site we should try to use it.

@github-actions
Copy link

Hi,
This issue has gone 180 days without any activity. This means it is time for a check-in to make sure it is still relevant. If you are still experiencing this issue with the latest versions, you can help the project by responding to confirm the problem and by providing any updated reproduction steps.
Thanks for helping out.

@github-actions github-actions bot added the Needs Testing Needs further testing to be confirmed. label Sep 27, 2022
@getdave
Copy link
Contributor Author

getdave commented Sep 27, 2022

This Issue has been completed by #42735 and others. Closing as complete.

@getdave getdave closed this as completed Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block Needs Testing Needs further testing to be confirmed.
Projects
None yet
Development

No branches or pull requests

2 participants