Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Font Family dropdown to individual blocks in global Styles #39981

Open
Tracked by #38534
bradhogan opened this issue Apr 1, 2022 · 1 comment
Open
Tracked by #38534

Add Font Family dropdown to individual blocks in global Styles #39981

bradhogan opened this issue Apr 1, 2022 · 1 comment
Labels
[Feature] Blocks Overall functionality of blocks Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Enhancement A suggestion for improvement.

Comments

@bradhogan
Copy link

What problem does this address?

Currently, you can add as many fonts as you'd like to your theme, register them in the theme.json and functions file and those fonts will appear in the global Styles > Typography > Font Family dropdown. However, if you want to make a global edit to a specific block (Quote block for example), you can go to Styles > Blocks > Quote > Typography > and you can change size, line-height and letter spacing, but not the font family.

What is your proposed solution?

It would be great to add a font family section to the global styles typography options for individual blocks. If I wanted my entire site to use a sans-serif type for heading and body but add a little flare and have the quote use a monospace font, I'd like to be able to change that in the global Styles and not in the theme files.

Screen Shot 2022-04-01 at 9 00 53 AM

Screen Shot 2022-04-01 at 9 00 57 AM

@bph bph added the Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json label Apr 1, 2022
@Addison-Stavlo
Copy link
Contributor

Some blocks do have support for font families here (such as post title and site title), but I think more blocks definitely need to add support for this feature.

For example, here is a PR I just opened to enable it for the core/heading block.

I don't think the plan is for all blocks to support this, but at the very least a list of blocks that make sense (I think your example of the quote block would make sense as well!)

@mtias mtias added the [Feature] Blocks Overall functionality of blocks label May 23, 2022
@jordesign jordesign added the [Type] Enhancement A suggestion for improvement. label Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Blocks Overall functionality of blocks Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

5 participants