Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FSE Link Styles: can we have an option to control underlines? #40002

Closed
Tracked by #40966
supernovia opened this issue Apr 3, 2022 · 4 comments · Fixed by #45643
Closed
Tracked by #40966

FSE Link Styles: can we have an option to control underlines? #40002

supernovia opened this issue Apr 3, 2022 · 4 comments · Fixed by #45643
Assignees
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Enhancement A suggestion for improvement.

Comments

@supernovia
Copy link

supernovia commented Apr 3, 2022

What problem does this address?

Sometime site owners like their links to be underlined. Others want to turn underlines off. I would expect this option to be under Styles > Typography > Links, and there is an Appearance option there, but it seems to just be font weights. Currently underline is handled by the theme itself, and themes aren't consistent in this. Telling someone to just switch to another FSE theme, and lose all of their customizations, is suboptimal.

What is your proposed solution?

We have a Links appearance option under Colors, and another under Typography. Typography could have something as simple as a checkbox to underline links.

I would hope to be able to set this for the a full-site style as well an option to override it for some blocks (so we can underline in entry-content without having to underline in buttons or in nav, for example).

Here's a screenshot of where I thought the option would be. An underline checkbox above it would probably do.
Screen Shot 2022-04-03 at 12 10 23 PM
.

@ndiego ndiego added [Type] Enhancement A suggestion for improvement. Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json labels Apr 3, 2022
@masteradhoc
Copy link
Contributor

+1

@iwasthesword
Copy link

It would be great to have this, but I'd suggest going the long way and have this be added as "Decoration" (from css: text-decoration) as to support everything this css property has which includes underline, overline and line-through, as well as color, style and thickness

@supernovia
Copy link
Author

I'm realizing from this case that decoration may be important for this to be an option for individual links, too:
https://wordpress.com/forums/topic/making-groups-clickable/

@paaljoachim
Copy link
Contributor

Check out this issue:
#30701

@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Nov 9, 2022
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants