Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spacing support for max() #40344

Open
Azragh opened this issue Apr 14, 2022 · 0 comments
Open

Spacing support for max() #40344

Azragh opened this issue Apr 14, 2022 · 0 comments
Labels
[Type] Enhancement A suggestion for improvement.

Comments

@Azragh
Copy link

Azragh commented Apr 14, 2022

What problem does this address?

The problem with the new spacing specifications is that no distinction can be made between mobile devices and the desktop view. I therefore only allow "em" and "%" in my themes, but this only works to a limited extent.

Suppose I have 2 columns - one with an inner spacing of 4em, the other 5%. On the desktop, the whole thing looks nice and uniform:

image

On mobile devices, however, the spacing of the column with percentage is felt to be a bit too small, and the one with "em" a bit too big:

image

What is your proposed solution?

A solution would be to add a field in which a second value can be specified, which then results in padding: max(value1, value2);. In this way, values could be combined with each other as desired in order to better control the mobile view. Example with max(5%, 2em):

image

image

@ndiego ndiego added the [Type] Enhancement A suggestion for improvement. label Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

2 participants