Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BottomSheet height doesn't adjust to display low contrast error after tapping back button #40727

Open
SiobhyB opened this issue Apr 29, 2022 · 0 comments
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Type] Bug An existing feature does not function as intended

Comments

@SiobhyB
Copy link
Contributor

SiobhyB commented Apr 29, 2022

Description

When adding text/background colours with low contrast to a block and then tapping the back button, it’s sometimes necessary to scroll to see the low contrast error message. This reduces the visibility of the error message, as it's not obvious you need to scroll.

This issue is only apparent when tapping the back button immediately after selecting the colours. The message is visible immediately when clicking out and back into the settings.

Note, this is also not an issue on sites where a block-based theme is enabled. The reason for is that font-size options are displayed below the colour settings for block-based themes, which prevents the need to scroll to see the low contrast error.

Step-by-step reproduction instructions

Pre-requisite: The test site's theme should not be block-based.

  1. Open the editor for your test site in the WordPress Android or iOS app.
  2. Add a block that support changes to the text/background colours, such as the paragraph block.
  3. Select the settings cog and then select background/text colours with low contrast.
  4. Tap the back button.

Expected behaviour

I expect to see a low contrast error message after pressing the back button.

Actual behaviour

The error message is only available by scrolling. However, if I tap out of the settings and back in again, the message is immediately visible.

Possibly relevant issues: #28632, #37559

Screenshots or screen recording

After tapping back button After existing/re-entering settings

Device information

  • Device: Pixel 6
  • Operating system: Android 12
  • WordPress app version: 19.7-rc-1
@SiobhyB SiobhyB added Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [a11y] Color Contrast [Type] Bug An existing feature does not function as intended labels Apr 29, 2022
@priethor priethor added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). and removed [a11y] Color Contrast labels Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

2 participants