Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation: New menus are locked by default #40822

Closed
jameskoster opened this issue May 4, 2022 · 5 comments
Closed

Navigation: New menus are locked by default #40822

jameskoster opened this issue May 4, 2022 · 5 comments
Labels
[Type] Bug An existing feature does not function as intended

Comments

@jameskoster
Copy link
Contributor

jameskoster commented May 4, 2022

To reproduce:

  • Enable the Navigation experiment in Gutenberg settings
  • Open "Navigation (beta)"
  • Enter a name to create the menu
  • Notice that you cannot immediately edit the menu because it is locked.

Video:

locked.mp4

Edit: Possibly related, but even when unlocked I cannot add all pages or start empty:

bug.mp4
@jameskoster jameskoster added [Type] Bug An existing feature does not function as intended [Feature] Navigation Screen labels May 4, 2022
@Mamaduka
Copy link
Member

Mamaduka commented May 4, 2022

Hi, @jameskoster

This is probably related to #40263. The editor uses template lock for main navigation block, so the lock status is inherited.

Second is known bug, but since screen development is on hold for now, I don't think it's priority to fix the issue.

@getdave
Copy link
Contributor

getdave commented May 5, 2022

The editor uses template lock for main navigation block

Oh! Since when?

@Mamaduka
Copy link
Member

Mamaduka commented May 5, 2022

I'm not sure when this change was introduced, but it's there :)

settings={ {
...blockEditorSettings,
templateLock: 'all',
} }

@talldan
Copy link
Contributor

talldan commented May 6, 2022

Enable the Navigation experiment in Gutenberg settings

There are quite a few issues with the navigation editor because of changes to the block. Maybe it's worth removing this setting and ensuring the editor isn't enabled for anyone (the code for the editor can stay, but perhaps the project is considered 'mothballed').

I don't think there's any active effort to solve the issues and my concern is that it's confusing or might break things for users.

I'm not sure when this change was introduced, but it's there :)

I think from the very start. The navigation block isn't removable since that's the main (only) way users can build menus.

The nav block's inner blocks are unlocked here:

// Template lock set to false here so that the Nav
// Block on the experimental menus screen does not
// inherit templateLock={ 'all' }.
templateLock: false,

I don't think the inability to edit the block is caused by template lock, but more likely other bugs.

There were more recently some discussions about not using a navigation block at all, which would solve this particular issue—it'd be more like a BlockEditorProvider that has the same configuration as the nav block (allowed blocks etc).

@kathrynwp
Copy link

Closing this issue due to the Navigation Screen project being moved to an inactive status on the feature projects page in coordination with the project leads. (The developer documentation in the initial post are no longer accessible)

If this work is picked back up, issues can be revisited and reopened as needed. Thanks for pitching in on this early feature so the wider WordPress project could benefit from the lessons learned!

@kathrynwp kathrynwp closed this as not planned Won't fix, can't repro, duplicate, stale Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

5 participants