-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Navigation: New menus are locked by default #40822
Comments
Hi, @jameskoster This is probably related to #40263. The editor uses template lock for main navigation block, so the lock status is inherited. Second is known bug, but since screen development is on hold for now, I don't think it's priority to fix the issue. |
Oh! Since when? |
I'm not sure when this change was introduced, but it's there :) gutenberg/packages/edit-navigation/src/components/layout/index.js Lines 125 to 128 in ad2a96b
|
There are quite a few issues with the navigation editor because of changes to the block. Maybe it's worth removing this setting and ensuring the editor isn't enabled for anyone (the code for the editor can stay, but perhaps the project is considered 'mothballed'). I don't think there's any active effort to solve the issues and my concern is that it's confusing or might break things for users.
I think from the very start. The navigation block isn't removable since that's the main (only) way users can build menus. The nav block's inner blocks are unlocked here: gutenberg/packages/block-library/src/navigation/edit/inner-blocks.js Lines 134 to 137 in 6f11e0b
I don't think the inability to edit the block is caused by template lock, but more likely other bugs. There were more recently some discussions about not using a navigation block at all, which would solve this particular issue—it'd be more like a BlockEditorProvider that has the same configuration as the nav block (allowed blocks etc). |
Closing this issue due to the Navigation Screen project being moved to an inactive status on the feature projects page in coordination with the project leads. (The developer documentation in the initial post are no longer accessible) If this work is picked back up, issues can be revisited and reopened as needed. Thanks for pitching in on this early feature so the wider WordPress project could benefit from the lessons learned! |
To reproduce:
Video:
locked.mp4
Edit: Possibly related, but even when unlocked I cannot add all pages or start empty:
bug.mp4
The text was updated successfully, but these errors were encountered: