Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color reset trigger is missing in 6.0-RC1 #40960

Closed
imnavanath opened this issue May 10, 2022 · 3 comments
Closed

Color reset trigger is missing in 6.0-RC1 #40960

imnavanath opened this issue May 10, 2022 · 3 comments
Labels
[Feature] Colors Color management Needs Design Feedback Needs general design feedback. Needs Testing Needs further testing to be confirmed. [Package] Block editor /packages/block-editor

Comments

@imnavanath
Copy link

imnavanath commented May 10, 2022

Description

In editor the color picker don't have "Reset" trigger in the version of 6.0-RC1.
Core trac - https://core.trac.wordpress.org/ticket/55707
Screenshot - https://share.bsf.io/2Nuz4q0o

  • Issue reproducible in - 6.0-RC1
  • With theme - 2022

Step-by-step reproduction instructions

Check editor any color picker in WP-6.0-RC1

Screenshots, screen recording, code snippet

https://share.bsf.io/2Nuz4q0o

Environment info

WordPress version: 6.0-RC1
Browser used: Chrome
System info: Windows with 10

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@gziolo gziolo added [Package] Block editor /packages/block-editor [Feature] Colors Color management Needs Testing Needs further testing to be confirmed. labels May 11, 2022
@glendaviesnz glendaviesnz added the Needs Design Feedback Needs general design feedback. label May 16, 2022
@glendaviesnz
Copy link
Contributor

I was able to replicate this. It is because clearable is set to false here, which I think was a deliberate design decision to remove reset/clear buttons when there was also a reset option in the ToolsPanel dropdown. I can't find an issue that explicitly states this though.

It would be easy to toggle this back on, but I think we should get some design input before doing so.

@aaronrobertshaw
Copy link
Contributor

One of the goals of the ToolsPanel design was to reduce the proliferation of reset and clear buttons as more controls were added to the inspector controls sidebar. I believe this was part of #27331 though I'm a little short on time and haven't been able to dig too far into it to locate the exact comment or sub-issue that might have explicitly stated that intent.

When the color panel was switched to use the ToolsPanel, the clearable flag was set to false for the block support color controls then.

@ndiego
Copy link
Member

ndiego commented May 16, 2022

Yes, this was a deliberate design change. Note that you can reset colors using the dropdown. See the gif below.

Since this change is intentional in 6.0+ I am going to close this issue, be please let me know if there are any further questions or concerns.

color-reset

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Colors Color management Needs Design Feedback Needs general design feedback. Needs Testing Needs further testing to be confirmed. [Package] Block editor /packages/block-editor
Projects
None yet
Development

No branches or pull requests

5 participants