Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bottom Sheet Rows Get Selected Twice When Talkback is enabled. #41059

Open
mchowning opened this issue May 13, 2022 · 3 comments
Open

Bottom Sheet Rows Get Selected Twice When Talkback is enabled. #41059

mchowning opened this issue May 13, 2022 · 3 comments
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) Needs Accessibility Feedback Need input from accessibility

Comments

@mchowning
Copy link
Contributor

Description

On Android, when using talkback, bottom sheet cells with toggles get selected twice: once for the row as a whole which has the helpful description you're updating in this PR, and then it will highlight just the button, speaking something vague like "Off. Switch. Double tap to toggle."

Step-by-step reproduction instructions

  1. Add a latest posts block to the demo app on Android
  2. Open the settings bottom sheet for that block
  3. Enable Talkback
  4. Observe that you have to cycle through each toggle twice

Expected behaviour

Each toggle should only be selected once. It would be great to get some confirmation from someone more familiar with the accessibility expectations here. I do notice that on iOS, I'm seeing the expected behavior (each toggle is only selected once).

Actual behaviour

Each toggle is selected twice.

Screenshots or screen recording (optional)

device-2022-05-13-090735.mp4

Device information

@mchowning mchowning added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) Needs Accessibility Feedback Need input from accessibility labels May 13, 2022
@joedolson
Copy link
Contributor

This doesn't appear to still be occurring in the latest version of the mobile app, but I'm not 100% certain of the reproduction steps here. Can @mchowning confirm whether this is still an issue?

Tested on Galaxy S21/ Android 13.

@joedolson
Copy link
Contributor

Pinging @hypest; we're not able to reproduce this, but don't really know whether anything changed.

@hypest
Copy link
Contributor

hypest commented May 2, 2024

👋 @joedolson , thanks for the ping!

I'm able to replicate the issue following the steps in the issue description, using the current WordPress mobile app from Play Store (v24.8-rc-2). In fact, looks like there's now an extra element between the text and the toggle switch itself, and it gets selected during Talkback scrolling:

Screen_Recording_20240502_105101_WordPress.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) Needs Accessibility Feedback Need input from accessibility
Projects
None yet
Development

No branches or pull requests

3 participants