Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template panel: "Default template" can be a confusing option label #41449

Closed
Tracked by #41241
jameskoster opened this issue May 31, 2022 · 9 comments
Closed
Tracked by #41241

Template panel: "Default template" can be a confusing option label #41449

jameskoster opened this issue May 31, 2022 · 9 comments
Labels
[Feature] Template Editing Mode Related to the template editor available in the Block Editor [Status] Blocked Used to indicate that a current effort isn't able to move forward [Type] Enhancement A suggestion for improvement.

Comments

@jameskoster
Copy link
Contributor

Screenshot 2022-05-31 at 09 14 20

All options in the dropdown explicitly use the template name as the label, except for the "Default template" option. This can be confusing if you then go to the Site Editor to edit this template, only to find that "Default template" doesn't exist.

Suggestion:

Update the default template option to state the template name, with '(default)' appended.

Screenshot 2022-05-31 at 09 17 30

@jameskoster jameskoster added the [Feature] Template Editing Mode Related to the template editor available in the Block Editor label May 31, 2022
@annezazu annezazu added the [Type] Enhancement A suggestion for improvement. label May 31, 2022
@Mamaduka
Copy link
Member

Mamaduka commented Jul 1, 2022

@jameskoster, with recent refactoring (#41925), what do you think if we display the template name as a button label, but leave "Default template" in the drop down?

CleanShot 2022-07-01 at 11 38 03

@jameskoster
Copy link
Contributor Author

Personally I think that's a bit confusing – two elements in the UI seem to be telling me different things. Appending "(default)" to the default template name still seems the best way to provide clarity imo.

@annezazu
Copy link
Contributor

Noting that feedback came in from the fifteenth call for testing from the FSE Outreach Program about how confusing this current experience is:

So I would prefer if it said “Template Single” instead of “Template Default Template”. Or maybe “Template Single (Default)”, though I don’t see how being shown Single is the default is really helpful at that moment.

@priethor
Copy link
Contributor

priethor commented May 8, 2023

I'm unassigning the issue since Jorge is not currently available so that somebody else can pick it up 🙂

@apeatling apeatling moved this from Needs development to In progress in Polish Jun 6, 2023
@priethor priethor moved this from In progress to Needs development in Polish Jul 6, 2023
@jorgefilipecosta
Copy link
Member

I had a PR that fixed this issue #45865. Fixing this issue is not something simple and involves computing the template that would be used if there was no template currently assigned to a post. Which is a special template resolution case and replicates some logic already existing in the core that is not extracted and reusable. At the time @youknowriad referred the added complexity to the codebase may not be worth the UX improvement and so the PR was closed. I don't think the situation changed meanwhile.

@jordesign
Copy link
Contributor

Ah - that definitely makes it more complicated - thanks for the additional context @jorgefilipecosta

@carolinan carolinan added the [Status] Blocked Used to indicate that a current effort isn't able to move forward label Jan 15, 2024
@carolinan carolinan removed this from Polish Jan 15, 2024
@MikeG14
Copy link

MikeG14 commented Jan 21, 2024

I don't know where this went after the discussion, but - I'm new to Wordpress and I have to agree that seeing "Default Template" in drop-downs for selection, and then looking for "Default Template" in the template list and not finding it, is frustrating and confusing. Is there any mechanism that can be used to identify which template is the "Default Template"?

@annezazu
Copy link
Contributor

Hey @MikeG14 thanks for chiming in on this discussion and for taking the time to find it. It's very helpful to hear feedback from folks like yourself. In terms of finding the default, I've heard recommendations from folks to try leaving a paragraph block with the word "test" or something similar in templates to help determine which is the default. After leaving some "test" text in the template you think is likely the default, you can then confirm if that properly shows up.

Of note, there's a new experience coming to WordPress 6.5 around swapping templates that you might be interested in:

new.template.mov

There's some discussion around the phrasing there too in case you have any thoughts: #56845

If you're on WordPress.org slack, feel free to message me there (I'm @annezazu) and I can dig into your theme to figure it out for you too.

@youknowriad
Copy link
Contributor

The applied template is now rendered properly. It seems this issue is fixed unless I'm missing something.

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Template Editing Mode Related to the template editor available in the Block Editor [Status] Blocked Used to indicate that a current effort isn't able to move forward [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants