Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight text: Color of highlighted text is not preserved when setting text color in the text block #41462

Closed
fluiddot opened this issue May 31, 2022 · 2 comments · Fixed by #57650
Labels
[Feature] Colors Color management Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Type] Bug An existing feature does not function as intended

Comments

@fluiddot
Copy link
Contributor

Description

On a text block (e.g. Paragraph block) setting a text color changes the color displayed for all its content, including the parts that are highlighted with a different color. This behavior differs from the web version of the editor.

Step-by-step reproduction instructions

  1. Add a Paragraph block.
  2. Type some text.
  3. Select a word.
  4. Tap on the Highlight text format button located in the toolbar (i.e. the (A) button).
  5. Select a color different from the currently displayed.
  6. Observe that the selected text is displayed with the color picked.
  7. Tap on the ⚙️ button.
  8. Tap on "Text" button.
  9. Select a color different from the currently displayed.
  10. Observe that all text is displayed with the color picked, including the previously highlighted.

Expected behaviour

The highlighted text should preserve its color when setting text color to the text block.

Actual behaviour

The color of highlighted text is not preserved when setting text color to the text block.

Screenshots or screen recording (optional)

ios-highlight-text.mp4

WordPress information

  • WordPress version: N/A
  • Gutenberg version: N/A
  • Are all plugins except Gutenberg deactivated? N/A
  • Are you using a default theme (e.g. Twenty Twenty-One)? N/A

Device information

  • Device: iPhone 13 (simulator)
  • Operating system: iOS 15.4
  • WordPress app version: trunk
@fluiddot fluiddot added [Type] Bug An existing feature does not function as intended Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) labels May 31, 2022
@fluiddot fluiddot changed the title Highlight text: Color of highlighted text is not preserved when setting text color to a text block Highlight text: Color of highlighted text is not preserved when setting text color in the text block May 31, 2022
@fluiddot fluiddot added [Priority] High Used to indicate top priority items that need quick attention [Feature] Colors Color management labels Jul 11, 2022
@SiobhyB
Copy link
Contributor

SiobhyB commented Dec 20, 2023

Tested and confirmed I could reproduce this on iOS in the latest version of the app (23.8.1). The issue is not reproducible on Android.

@geriux
Copy link
Member

geriux commented Jan 12, 2024

I have a fix for this that I'm working on currently so I'll remove the High priority label.

@geriux geriux removed the [Priority] High Used to indicate top priority items that need quick attention label Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Colors Color management Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Type] Bug An existing feature does not function as intended
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants