Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Image block, Initial state on popup incorrect. #41473

Closed
richardmorrison opened this issue Jun 1, 2022 · 4 comments · Fixed by #41678
Closed

Add Image block, Initial state on popup incorrect. #41473

richardmorrison opened this issue Jun 1, 2022 · 4 comments · Fixed by #41678
Labels
[Block] Image Affects the Image Block [Type] Bug An existing feature does not function as intended

Comments

@richardmorrison
Copy link

Description

Using the Image Block in Gutenberg, when selecting the Media Library option, the pop up starts on the Upload tab, not the Media Library tab. And also stays on the selected option, when closing and re-opening the pop up.

Screen Shot 2022-06-01 at 12 39 01 PM

Step-by-step reproduction instructions

  1. Create new post.
  2. Add Image block.
  3. Select Media Library to find image.

Screen Shot 2022-06-01 at 12 40 00 PM

4. Pop up dialog shows the Upload Files tab first.

Screen Shot 2022-06-01 at 12 41 03 PM

5. If Media Library tab is selected, on closing the pop up modal, on reopening, it stays on Media Library.. though the same happens if Upload Files tab is selected. Eg: It stays on selected state.

Screenshots, screen recording, code snippet

gutenberg-image-upload-bug

Environment info

WordPress 6.0 without Gutenberg plugin.

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@kathrynwp kathrynwp added [Block] Image Affects the Image Block [Type] Bug An existing feature does not function as intended labels Jun 1, 2022
@kathrynwp
Copy link

Hi @richardmorrison – thanks for the report!

I was not able to replicate this issue with WordPress 6.0, either with or without the Gutenberg plugin active (v. 13.3.0).

Here's a screencast:

gbr-image-block.mov

Are you experiencing this only this one specific site, or on other sites running WP 6.0 as well?

@kathrynwp kathrynwp added the [Status] Needs More Info Follow-up required in order to be actionable. label Jun 1, 2022
@glendaviesnz
Copy link
Contributor

glendaviesnz commented Jun 9, 2022

@kathrynwp I was able to replicate this on WP 6.0 with latest GB trunk, but it only happens if you select the Upload tab in the media library modal and exit, an then click Media library again, eg. it remembers your last open tab:

default.mp4

I guess it could sometimes make sense to remember the last open tab of the media dialog, but it is a little confusing in this context as you have Upload and Media Library buttons and you click Media Library and end up on an Upload tab, and you don't necessarily make the connection that it was the tab you were last on last time you used the media library, and if you wanted to Upload first up you would probably use the upload button on the placeholder.

@carolinan
Copy link
Contributor

I am seeing the same result as Glen.

@akasunil
Copy link
Member

Have fixed this issue in PR 41678. Thanks

@kathrynwp kathrynwp removed the [Status] Needs More Info Follow-up required in order to be actionable. label Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Image Affects the Image Block [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants