Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Column blocks (e.g. 30) are not displayed correctly in a group block #42031

Closed
hagege opened this issue Jun 29, 2022 · 6 comments · Fixed by #53716
Closed

Column blocks (e.g. 30) are not displayed correctly in a group block #42031

hagege opened this issue Jun 29, 2022 · 6 comments · Fixed by #53716
Labels
[Feature] List View Menu item in the top toolbar to select blocks from a list of links. Needs Technical Feedback Needs testing from a developer perspective. [Package] Editor /packages/editor [Type] Bug An existing feature does not function as intended

Comments

@hagege
Copy link

hagege commented Jun 29, 2022

Description

If I insert many column blocks in a group block (in the mentioned example these are 30 column blocks - I copied the columns blocks and the last column block I labeled "the last one" in the movie), then the list is not shown completely.
As a workaround I have found the following solution: Delete a column block and undo the deletion afterwards. After that the list is shown correctly.
However, if I then leave the page and then edit this page again, then I have the same problem, which I then have to solve again via the mentioned workaround.

When I activate Gutenberg 13.5.1 the error is still present and after performing the workaround the error is fixed, but when I then exit the page and edit again the list is displayed correctly

Step-by-step reproduction instructions

  1. Create group block
  2. Column block with a column containing an image, heading and paragraph.
  3. I have copied this column block

Screenshots, screen recording, code snippet

issue_columns_in_group

Environment info

WordPress 6.0
Chrome
Gutenberg 13.5.1

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@carolinan carolinan added Needs Testing Needs further testing to be confirmed. [Block] Columns Affects the Columns Block labels Jun 29, 2022
@hagege
Copy link
Author

hagege commented Jun 29, 2022

I forgot to mention two more points:

  1. there is no problem in the frontend
  2. if you have more column blocks in the group block, more column blocks will not be shown in the dashboard.

@hagege
Copy link
Author

hagege commented Jun 29, 2022

Here an example with about 100 column blocks within a group block
list_with_many_columns_blocks_in_group_block

@carolinan carolinan added [Feature] List View Menu item in the top toolbar to select blocks from a list of links. and removed [Block] Columns Affects the Columns Block labels Jun 29, 2022
@t-hamano t-hamano added the [Type] Bug An existing feature does not function as intended label Jul 23, 2022
@t-hamano
Copy link
Contributor

I found that this problem is not limited to columns or group blocks.

In the list view, if there are 31 or more nested child blocks, the 31st and subsequent blocks are not displayed, including the next parent block.

109daed079757b2b06525a77f0c7da77.mp4

@t-hamano
Copy link
Contributor

t-hamano commented Jul 23, 2022

Looking at #35230, it appears that the initial rendering is limited to 30 blocks, which are rendered according to scrolling.
However, if there are more than 30 child blocks, I think the scroll rendering is not working for some reason.

@t-hamano t-hamano added Needs Technical Feedback Needs testing from a developer perspective. and removed Needs Testing Needs further testing to be confirmed. labels Aug 18, 2022
@jtnico
Copy link

jtnico commented Aug 29, 2022

@t-hamano I confirm the problem is not limited to columns or group blocks.
Test on wordpress 6.0.1 and also in gutenberg 13.9.0 (plugin)

Hope this bug will be fix soon because "List View" is very useful to build page/post containing lot of blocks.

@andrewserong
Copy link
Contributor

I believe I have a fix for this, over in #53716. The fix looks to update / refresh the list view's windowing calculation when the expanded state of blocks changes (expanding / collapsing anywhere in the tree).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] List View Menu item in the top toolbar to select blocks from a list of links. Needs Technical Feedback Needs testing from a developer perspective. [Package] Editor /packages/editor [Type] Bug An existing feature does not function as intended
Projects
No open projects
Status: Done
6 participants