Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move block Menu selection and "Start Empty" actions to inspector controls #42602

Closed
getdave opened this issue Jul 21, 2022 · 6 comments
Closed
Assignees
Labels
[Block] Navigation Affects the Navigation Block

Comments

@getdave
Copy link
Contributor

getdave commented Jul 21, 2022

What problem does this address?

When displayed on the editor canvas, the goal should be that the Navigation block should - as far as is possible - remain 1:1 with what is displayed on the front of the site.

An effort is underway to improve the fallback states for the block so that they mirror what is displayed on the front of the site and require no user interaction to "just work".

What is your proposed solution?

Therefore to reduce UI clutter and noise we should move secondary block actions for Select Menu and Start empty to the inspector controls.

This will allow the block fallback states to remain 1:1 with the front of the site whilst also still affording the ability to take actions to force the block to a specific state if required.

Note that this effort is important because when displaying a list of Pages as a fallback, it would be difficult to show the block actions alongside the Page List block in the canvas.

@getdave
Copy link
Contributor Author

getdave commented Aug 1, 2022

@javierarce Would it be possible to look into the design of this?

@mtias mtias added the Needs Design Needs design efforts. label Aug 1, 2022
@javierarce javierarce self-assigned this Aug 2, 2022
@javierarce
Copy link
Contributor

A bit of a tangential question related to #42563 and this issue: what would happen if a user with no pages and no other menus adds a navigation block? Should we render an empty navigation with an inserter or do we fall back to a placeholder state?

@javierarce
Copy link
Contributor

Here are a couple of ideas:

The first one uses a custom dropdown that includes the list of menus and an option to create an empty new one.

image

The second idea is to present a regular dropdown and show the option to create menus directly on the sidebar along with the link to manage the menus.

image

@priethor priethor removed the Needs Design Needs design efforts. label Aug 22, 2022
@getdave
Copy link
Contributor Author

getdave commented Aug 22, 2022

Thank you for this design @javierarce 🙇‍♂️ 🙇‍♂️ 🙇‍♂️

The first one uses a custom dropdown that includes the list of menus and an option to create an empty new one.

This has a least visual "noise". The create empty action is likely a 20% use case and so probably doesn't need to be visible at all times.

@draganescu
Copy link
Contributor

I am picking up this one. I erroneously based #42987 on different designs but now I'm on the right track :D

@scruffian
Copy link
Contributor

This was closed by #42987

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block
Projects
None yet
Development

No branches or pull requests

6 participants