-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move button block width control into Dimensions #42644
Labels
[Block] Buttons
Affects the Buttons Block
Needs Design
Needs design efforts.
[Type] Enhancement
A suggestion for improvement.
Comments
richtabor
added
[Type] Enhancement
A suggestion for improvement.
[Block] Buttons
Affects the Buttons Block
labels
Jul 22, 2022
somewhat related: a PR that moves the width setting to theme.json and give user the ability to disable the width control as well #42079 |
The design should also probably switch to the segmented control |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Block] Buttons
Affects the Buttons Block
Needs Design
Needs design efforts.
[Type] Enhancement
A suggestion for improvement.
What problem does this address?
Setting a width of a button should be considered a dimension, and moved to that panel.
Do we have insights on the frequency/usage of the width setting? Looking at the pattern directory it seems a width is applied less often. I'm thinking it may be better as turned off by default within the Dimensions tool-belt.
Current:
What is your proposed solution?
Move the Width settings from its own panel to the Dimensions tool-belt, cleaning up the UI a bit.
CleanShot.2022-07-22.at.12.25.10.mp4
The text was updated successfully, but these errors were encountered: