Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move button block width control into Dimensions #42644

Open
richtabor opened this issue Jul 22, 2022 · 2 comments
Open

Move button block width control into Dimensions #42644

richtabor opened this issue Jul 22, 2022 · 2 comments
Labels
[Block] Buttons Affects the Buttons Block Needs Design Needs design efforts. [Type] Enhancement A suggestion for improvement.

Comments

@richtabor
Copy link
Member

What problem does this address?

Setting a width of a button should be considered a dimension, and moved to that panel.

Do we have insights on the frequency/usage of the width setting? Looking at the pattern directory it seems a width is applied less often. I'm thinking it may be better as turned off by default within the Dimensions tool-belt.

Current:

CleanShot 2022-07-22 at 12 42 41@2x

What is your proposed solution?

Move the Width settings from its own panel to the Dimensions tool-belt, cleaning up the UI a bit.

CleanShot.2022-07-22.at.12.25.10.mp4

CleanShot 2022-07-22 at 12 27 48@2x

@richtabor richtabor added [Type] Enhancement A suggestion for improvement. [Block] Buttons Affects the Buttons Block labels Jul 22, 2022
@skorasaurus
Copy link
Member

skorasaurus commented Jul 24, 2022

somewhat related: a PR that moves the width setting to theme.json and give user the ability to disable the width control as well #42079

@mtias
Copy link
Member

mtias commented Jul 26, 2022

The design should also probably switch to the segmented control

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Buttons Affects the Buttons Block Needs Design Needs design efforts. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

3 participants