Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drag and drop resets after dragging down over blocks #42840

Closed
talldan opened this issue Aug 1, 2022 · 0 comments · Fixed by #42877
Closed

Drag and drop resets after dragging down over blocks #42840

talldan opened this issue Aug 1, 2022 · 0 comments · Fixed by #42877
Assignees
@talldan
Labels
[Feature] Blocks Overall functionality of blocks [Feature] Drag and Drop Drag and drop functionality when working with blocks [Type] Bug An existing feature does not function as intended

Comments

@talldan
Copy link
Contributor

talldan commented Aug 1, 2022

Description

When dragging a block the dragged block is initially 'greyed out' , but when you drag past its position it suddenly reappears even though the user hasn't stopped dragging. The BlockDraggable is unmounted and stopDraggingBlocks is called.

When bisecting I discovered this bug was introduced in #38892.

Step-by-step reproduction instructions

  1. Open the post editor with some lengthy content.
  2. Start dragging a block from near the top up initially, then down the page.
  3. Observe that the 'greyed out' block reappears and the draggable chip disappears

Screenshots, screen recording, code snippet

Kapture.2022-07-29.at.13.23.21.mp4

Environment info

Mac OS / Brave

Latest trunk

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes
@talldan talldan added [Type] Bug An existing feature does not function as intended [Feature] Blocks Overall functionality of blocks [Feature] Drag and Drop Drag and drop functionality when working with blocks labels Aug 1, 2022
This was referenced Aug 1, 2022
Closed
Merged
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Aug 2, 2022
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@talldan talldan

Labels
[Feature] Blocks Overall functionality of blocks [Feature] Drag and Drop Drag and drop functionality when working with blocks [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prevent multiselection via dragging when already dragging blocks WordPress/gutenberg
2 participants
@talldan @priethor