Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Editor: Root padding support in theme.json and no colors #42913

Closed
Gierand opened this issue Aug 3, 2022 · 2 comments · Fixed by #42954
Closed

Site Editor: Root padding support in theme.json and no colors #42913

Gierand opened this issue Aug 3, 2022 · 2 comments · Fixed by #42954
Assignees

Comments

@Gierand
Copy link

Gierand commented Aug 3, 2022

Description

Adding support for root padding in theme.json causes no color rendering in the Site Editor.

Step-by-step reproduction instructions

Depending on the setting in useRootPaddingAwareAlignments in theme.json, follow the video demonstration below.

Screenshots, screen recording, code snippet

Before:

"settings": {
   "useRootPaddingAwareAlignments": false
}

before

After:

"settings": {
   "useRootPaddingAwareAlignments": true
}

after

Environment info

WordPress version: 6.0.1 and 6.1-alpha-53810
Gutenberg version: 13.9.20220731

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@tellthemachines
Copy link
Contributor

Thanks for reporting this @Gierand !

I can reproduce the issue on trunk with Empty Theme. Looks like it's caused by the early return after root padding variables are set.

It only happens in the editor though, not on the front end. Looking into a fix now.

@spencerfinnell
Copy link

Thanks for the quick fix. In case anyone else is searching as a result of a similar consequence, it was also affecting typography options like fontWeight and lineHeight. Confirmed fix on trunk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants