Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a standard "controls grid" component for sidebar #43423

Open
mirka opened this issue Aug 19, 2022 · 5 comments
Open

Implement a standard "controls grid" component for sidebar #43423

mirka opened this issue Aug 19, 2022 · 5 comments
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Package] Components /packages/components [Type] Enhancement A suggestion for improvement.

Comments

@mirka
Copy link
Member

mirka commented Aug 19, 2022

What problem does this address?

The controls in the sidebar should be laid out in a consistent grid, whether they are in edit-post (ToolsPanel) or edit-site (ad hoc layouts). Currently they each do their own styling for rowGap/columnGap, column count, and full-width items.

What is your proposed solution?

Try making a standard layout component for this purpose, so they can be easily reused in either context. We can call it something like ControlsGrid.

@mirka mirka added the [Package] Components /packages/components label Aug 19, 2022
@ciampo
Copy link
Contributor

ciampo commented Aug 19, 2022

This could be an interesting exploration to inform some of the decision re. grid components discussed in #43085

@jasmussen
Copy link
Contributor

Here's a suggested grid:

Grid

Is that helpful?

@jasmussen
Copy link
Contributor

I went ahead and created a separate issue for updating the default component sizes: #46734

@mirka
Copy link
Member Author

mirka commented May 23, 2023

Relevant: An implementation of the boundary-breaking buttons in the header labels #50855

@jordesign jordesign added the [Type] Enhancement A suggestion for improvement. label Sep 1, 2023
@afercia afercia added the [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). label Jul 25, 2024
@afercia
Copy link
Contributor

afercia commented Jul 25, 2024

Comine here from #63806
Although this is somehow an old issue, I'd like to add a couple considerations:

Personally, I'm not sure the inconsistency in the placement of the 'Set custom size' toggle button helps with providing the highest level of usability and accessibility. Currently, this button is placed in a different spot depending on the control. Example screenshot:

Screenshot 2024-07-25 at 08 37 49

Sometimes the order is:

  1. Label
  2. Toggle
  3. Control

Sometimes is:

  1. Label
  2. Control
  3. Toggle

From a logical order perspective, I would expect this order:

  1. Label: it tells me what the control is about and it makes sense to have this information first.
  2. The control itself.
  3. Lastly, the option to switch the control to an alternative version.

What I would like to see from the design team is an effort to make design that goes beyond providing a balanced, visually pleasant, grid. I would like to see a functional analysis and consistency in the grouping and order of the controls.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Package] Components /packages/components [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

5 participants