-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement a standard "controls grid" component for sidebar #43423
Comments
This could be an interesting exploration to inform some of the decision re. grid components discussed in #43085 |
I went ahead and created a separate issue for updating the default component sizes: #46734 |
Relevant: An implementation of the boundary-breaking buttons in the header labels #50855 |
Comine here from #63806 Personally, I'm not sure the inconsistency in the placement of the 'Set custom size' toggle button helps with providing the highest level of usability and accessibility. Currently, this button is placed in a different spot depending on the control. Example screenshot: Sometimes the order is:
Sometimes is:
From a logical order perspective, I would expect this order:
What I would like to see from the design team is an effort to make design that goes beyond providing a balanced, visually pleasant, grid. I would like to see a functional analysis and consistency in the grouping and order of the controls. |
What problem does this address?
The controls in the sidebar should be laid out in a consistent grid, whether they are in
edit-post
(ToolsPanel) oredit-site
(ad hoc layouts). Currently they each do their own styling forrowGap
/columnGap
, column count, and full-width items.What is your proposed solution?
Try making a standard layout component for this purpose, so they can be easily reused in either context. We can call it something like
ControlsGrid
.The text was updated successfully, but these errors were encountered: