Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve label "Wide" in layout settings #43468

Open
MatzeKitt opened this issue Aug 22, 2022 · 4 comments
Open

Improve label "Wide" in layout settings #43468

MatzeKitt opened this issue Aug 22, 2022 · 4 comments
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). l10n Localization and translations best practices Needs Design Feedback Needs general design feedback. [Package] Block editor /packages/block-editor [Type] Bug An existing feature does not function as intended

Comments

@MatzeKitt
Copy link
Contributor

What problem does this address?

The current label "Wide" is not really clear what it means. It sets the width for the "Wide width" setting of any subblock. Additionally, only "Wide" as label is not properly translatable, at least in German, as a word-by-word translation would result in an information loss where the label would be not clear at all.

What is your proposed solution?

Rename the label to "Wide width" (and maybe the "Content" label to "Content width" to have it consistent) to make them more clear and also better translatable.

A plus for giving these labels a context for translations.

Bildschirmfoto 2022-08-22 um 09 41 07

@t-hamano
Copy link
Contributor

I agree with this proposal.
I think it is not currently consistent with the block toolbar.

wide

However, in the current UI, text does not fit, at least in English. In other languages, WIDE may be the same.
If we proceed with this proposal, I think the UI needs to be changed.

overflow

@t-hamano t-hamano added Needs Design Needs design efforts. [Type] Enhancement A suggestion for improvement. labels Aug 22, 2022
@mtias
Copy link
Member

mtias commented Sep 11, 2022

Doesn't the longer text above the controls provide enough context that it's about the different widths? We shouldn't have to repeat the "width" suffix on each label.

@mtias mtias added Needs Design Feedback Needs general design feedback. and removed Needs Design Needs design efforts. labels Sep 11, 2022
@MatzeKitt
Copy link
Contributor Author

Unfortunately, no. Even with multiple people in the team we needed quite some time to make sure we understood the settings correctly.

@afercia
Copy link
Contributor

afercia commented Aug 29, 2024

I wasn't aware of this issue and submitted a PR at #64891 associated to #64842

I do agree these two controls are unclear and confusing. Also, as commented on the PR:

I see a trend from the design team to shorten or truncate control labels only to make the controls 'fit' in specific design e.g. a two columns layout. This has the only effect to make the controls unclear for users. Features and settings must have clear, meaningful, understandable names. Please do not ever shorten labels only for visuals reasons.
Labeling a control by an adjective e.g. 'Wide' seems to me far from ideal and not the best UI.

Clarity should never be sacrificed in favor of a 'pretty' layout in two columns that doesn't add any funcitonal value to the UI. Functionality and operability come first and only then the design should accomodat ethe layout in the most possible efficient, usable, elegant, way.

Worth also mentioning that in the panel to reset these settins that can be opened by clicking the 'DImension opions' ellipsis icon button, these settings are currently cnamed 'Content size' and 'Wide size', there the term 'size' is inconsistend and confusing.

@afercia afercia added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Package] Block editor /packages/block-editor l10n Localization and translations best practices [Type] Bug An existing feature does not function as intended and removed Internationalization (i18n) Issues or PRs related to internationalization efforts [Type] Enhancement A suggestion for improvement. labels Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). l10n Localization and translations best practices Needs Design Feedback Needs general design feedback. [Package] Block editor /packages/block-editor [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

5 participants