Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add border to root level of global styles #43733

Open
carolinan opened this issue Aug 31, 2022 · 2 comments
Open

Add border to root level of global styles #43733

carolinan opened this issue Aug 31, 2022 · 2 comments
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Enhancement A suggestion for improvement.

Comments

@carolinan
Copy link
Contributor

carolinan commented Aug 31, 2022

What problem does this address?

If theme.json sets a broder style on the body, the user can not change or remove this border using global styles.

What is your proposed solution?

Add border settings to root level of global styles

@carolinan carolinan added Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Enhancement A suggestion for improvement. labels Aug 31, 2022
@carolinan
Copy link
Contributor Author

@WordPress/gutenberg-design Is there any interest in adding this to the Site Editor Styles sidebar? I don't see it being mentioned in overview issues or similar.

@jasmussen
Copy link
Contributor

Do you mean here, among typography, colors, layout?

Screenshot 2023-04-14 at 09 29 02

If yes, my instinct is to only keep the most high value global items there, and if it only sets the border on the body element, it seems to put a great deal of emphasis to something you would style in Blocks in most other cases. I know that Saxon has explored some changes to the Global Styles IA in #47348 and #47369, the latter notably having an "Elements" category that could potentially hold a "body" element.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

2 participants