-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translation note requested for "View options" #43809
Comments
Thanks for creating the issue, @NekoJonez. I can only see one "View options" string in the codebase. The "Preview options" was changed to "View options" in #42331. I'll quote the reasoning from the PR here:
Let me know if you have suggestions regarding the translator message, and I will be happy to push the changes. |
Does this appear on a button or as an option? Depending on that, I can give a suggestion on a translator note. |
Then I'd say as translator note: /* This is an aria-label for the view dropdown where you can choose if you want to preview on desktop, tablet or mobile. */ Or something among those lines. If I understood it correctly. Edit: I'm an IT admin in a school and with the start of the new schoolyear, I'm a bit too busy to contribute rn... So, if somebody else wants to do this it would be a god sent. |
Thank you, @NekoJonez. This is already a contribution 🦸 @jameskoster, do you have any suggestions? |
Checking this in WP6.3 and that button is back to 'preview' as the title and aria-label. Is the need for translation note still valuable here? |
Wow, I totally missed this notification, sorry @Mamaduka. The translation note seems valid to me. |
This needs to be resolved first. |
https://translate.wordpress.org/projects/wp-plugins/gutenberg/stable/nl-be/default/?filters%5Bstatus%5D=either&filters%5Boriginal_id%5D=14313136&filters%5Btranslation_id%5D=96600507
"View options"
Can this have a translator note, since is this:
A) A button to view the options OR
B) The options of the view/how things look OR
C) Something totally different.
The text was updated successfully, but these errors were encountered: