Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation note requested for "View options" #43809

Open
NekoJonez opened this issue Sep 2, 2022 · 8 comments
Open

Translation note requested for "View options" #43809

NekoJonez opened this issue Sep 2, 2022 · 8 comments
Labels
Internationalization (i18n) Issues or PRs related to internationalization efforts [Type] Enhancement A suggestion for improvement.

Comments

@NekoJonez
Copy link
Contributor

https://translate.wordpress.org/projects/wp-plugins/gutenberg/stable/nl-be/default/?filters%5Bstatus%5D=either&filters%5Boriginal_id%5D=14313136&filters%5Btranslation_id%5D=96600507

"View options"
Can this have a translator note, since is this:

A) A button to view the options OR
B) The options of the view/how things look OR
C) Something totally different.

@Mamaduka Mamaduka added the Internationalization (i18n) Issues or PRs related to internationalization efforts label Sep 2, 2022
@Mamaduka
Copy link
Member

Mamaduka commented Sep 2, 2022

Thanks for creating the issue, @NekoJonez.

I can only see one "View options" string in the codebase. The "Preview options" was changed to "View options" in #42331.

I'll quote the reasoning from the PR here:

As a part of this update I've changed 'Preview' to 'View' for a couple of reasons:

  1. There's no way to _pre_view site editor changes yet.
  2. The device view options aren't strictly previews, they are just view modes for the canvas.

Let me know if you have suggestions regarding the translator message, and I will be happy to push the changes.

@NekoJonez
Copy link
Contributor Author

Does this appear on a button or as an option? Depending on that, I can give a suggestion on a translator note.
Also, I still don't really get what the string is for. It's a preview, while in technical terms it can't be a preview?

@Mamaduka
Copy link
Member

Mamaduka commented Sep 2, 2022

The string is aria-label for post or site editor view options menu dropdown.

Screenshot

CleanShot 2022-09-02 at 18 19 44

@NekoJonez
Copy link
Contributor Author

NekoJonez commented Sep 2, 2022

Then I'd say as translator note:

/* This is an aria-label for the view dropdown where you can choose if you want to preview on desktop, tablet or mobile. */

Or something among those lines. If I understood it correctly.

Edit: I'm an IT admin in a school and with the start of the new schoolyear, I'm a bit too busy to contribute rn... So, if somebody else wants to do this it would be a god sent.

@Mamaduka
Copy link
Member

Mamaduka commented Sep 2, 2022

Thank you, @NekoJonez. This is already a contribution 🦸

@jameskoster, do you have any suggestions?

@jordesign
Copy link
Contributor

Checking this in WP6.3 and that button is back to 'preview' as the title and aria-label.

Is the need for translation note still valuable here?

@jordesign jordesign added the [Type] Enhancement A suggestion for improvement. label Sep 1, 2023
@jameskoster
Copy link
Contributor

Wow, I totally missed this notification, sorry @Mamaduka.

The translation note seems valid to me.

@Mamaduka Mamaduka reopened this Sep 4, 2023
@Mamaduka
Copy link
Member

Mamaduka commented Sep 4, 2023

This needs to be resolved first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internationalization (i18n) Issues or PRs related to internationalization efforts [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

4 participants