Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More granular control of wide/full block alignment options #4383

Closed
mattheu opened this issue Jan 10, 2018 · 1 comment
Closed

More granular control of wide/full block alignment options #4383

mattheu opened this issue Jan 10, 2018 · 1 comment

Comments

@mattheu
Copy link
Contributor

mattheu commented Jan 10, 2018

Currently, you can opt-in to the wide and full width block alignment options using add_theme_support( 'align-wide' ), however this assumes that all pages on your site either support this, or not.

My use case is that for posts I have a template with a sidebar, but for pages, the template can support full width blocks.

Theme support is a good catch all, but I suspect a common requirement would be for more granular control of this. Certainly at a post type level and a page template level (once implemented).

Perhaps this is already possible, or a duplicate of an existing ticket although I couldn't see one.

@youknowriad
Copy link
Contributor

Hi @mattheu that's a valid concern. However, we already discussed these APIs (can't find the issue unfortunately) and we settled on not being too granular but this will only create APIs not useful for most use-cases.

For example, some could argue that the support should be per block, others per CPT or even per CPT's template.

The concern was that we'll end up with hundreds of unused APIs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants