Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to redo text entry for List block #43875

Closed
dcalhoun opened this issue Sep 5, 2022 · 3 comments
Closed

Unable to redo text entry for List block #43875

dcalhoun opened this issue Sep 5, 2022 · 3 comments
Assignees
Labels
[Block] List Affects the List Block Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Priority] High Used to indicate top priority items that need quick attention [Type] Bug An existing feature does not function as intended

Comments

@dcalhoun
Copy link
Member

dcalhoun commented Sep 5, 2022

Description

When using undo and redo actions, it is not possible to add once removed list items back to the list. If the List block itself is not removed, then the bug does not occur.

Step-by-step reproduction instructions

  1. Insert a List block with the native editor.
  2. Add several list times.
  3. Tap the "undo" button to remove all the items and the list.
  4. Tap the "redo" button several times.

Expected behaviour

The List block is returned to the editor with all of the original list items.

Actual behaviour

An empty List block is placed in the editor. The "redo" button is disabled.

Screenshots or screen recording (optional)

RPReplay_Final1662405447.MP4

WordPress information

  • WordPress version: 6.1
  • Gutenberg version: 14.0.2
  • Are all plugins except Gutenberg deactivated? Yes
  • Are you using a default theme (e.g. Twenty Twenty-One)? Geologist

Device information

  • Device: iPhone SE
  • Operating system: iOS 16 beta 6
  • WordPress app version: 20.7
@dcalhoun dcalhoun added [Type] Bug An existing feature does not function as intended Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Block] List Affects the List Block labels Sep 5, 2022
@fluiddot fluiddot added the [Priority] High Used to indicate top priority items that need quick attention label Sep 15, 2022
@fluiddot fluiddot self-assigned this Sep 15, 2022
@fluiddot
Copy link
Contributor

I confirm this issue can also be reproduced in the web version, I opened a GitHub issue as a follow-up.

@fluiddot
Copy link
Contributor

I tried to debug the issue and shared the results in this comment. I haven't managed to find a workaround yet, probably I'll try to reach out to contributors that have more experience with the undo/redo mechanism, in case they could provide further guidance on how to approach it.

@geriux
Copy link
Member

geriux commented Jun 12, 2023

I've just checked this and I can confirm it is working now as expected on both the app and the web editor, there were some improvements done to this block and how it works inserting list items so I'm guessing one of those improvements solved this problem. I'll close this issue.

@geriux geriux closed this as completed Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] List Affects the List Block Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Priority] High Used to indicate top priority items that need quick attention [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

3 participants